Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove uuid4 #976

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Conversation

marco-ippolito
Copy link
Contributor

@marco-ippolito marco-ippolito commented Sep 26, 2023

chore: remove uuid4

  • Remove uuid4 and use native randomUUID.
  • Bump some deps are quested by commit hook

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2023

CLA assistant check
All committers have signed the CLA.

@marco-ippolito marco-ippolito changed the title Feat/remove uuid4 chore: remove uuid4 Oct 30, 2023
@marco-ippolito marco-ippolito force-pushed the feat/remove-uuid4 branch 2 times, most recently from 893c7f1 to 2b6e844 Compare October 30, 2023 11:46
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Looks good to me.

Always happy to see a reduction of 3rd party dependencies. Thanks for the contrib 🙏

@oderayi oderayi merged commit da9dbaf into mojaloop:main Nov 1, 2023
oderayi pushed a commit that referenced this pull request Nov 9, 2023
chore: remove uuid4
 - Remove uuid4 and use native randomUUID.
 - Bump some deps are quested by commit hook
kleyow added a commit that referenced this pull request Dec 5, 2023
* feat: added skeleton and comments for prepare bin implementation

* chore: some changes

* feat: added new position handler v2

* feat: added some functionality to new position handler v2

* feat: added some todos

* feat: changed new handler name

* fix: lint

* feat: add some changes

* fix: lint

* chore: added copyright header

* feat: added some logic

* fix: lint

* feat: added unit tests

* feat: some improvements

* feat: added bin processor logic

* fix: lint

* feat; refactor

* feat: added limit

* fix: unit tests

* feat: added integration test

* feat: refactor

* fix: unit tests

* fix: integration tests

* feat: add position prepare bin logic (#970)

* feat: add position prepare bin logic

* edit

* lint

* dep

* chore: changes

* chore: commet

* lint

* chore: refactor

* chore: unit tests

* chore: change

* chore: comment

* chore: test

* chore: more test

* chore: test?

* chore: remove

* chore: rework domain logic

* chore: test

* fix: position calculation

* fix: position change data

* fix; prepare domain function

* chore: fix

---------

Co-authored-by: Vijay <[email protected]>

* chore: add tests (#972)

* chore: add tests

* chore: unit

* sleep

* chore: clear

* chore: test

* enum

* fix: deadlock in tests

---------

Co-authored-by: Vijay <[email protected]>

* fix: metrics

* fix: some issue with bin processor

* feat(mojaloop/#3489): add cached calls for participant currency, update tests (#973)

* chore: add tests

* chore: unit

* sleep

* chore: clear

* chore: test

* enum

* feat: add cached calls for participant currency

* chore: change

* chore: unit

* chore: unit

* lock

* test

* fix: unit test

---------

Co-authored-by: Vijay <[email protected]>

* chore: improve coverage and edit metric and query name (#974)

* chore: coverage

* lint

* chore: coverage

* more coverage

* chore: test

* chore: coverage

* chore: metric name

* chore: metric name

* chore: update query name

* chore: remove log

* chore(snapshot): 17.3.0-snapshot.0

* fix: test downgrade stream lib

* chore(snapshot): 17.3.0-snapshot.1

* fix: notification event action

* chore(snapshot): 17.3.0-snapshot.2

* fix: notification event

* chore(snapshot): 17.3.0-snapshot.3

* fix: notification messages

* chore(snapshot): 17.3.0-snapshot.4

* chore: updated conf

* chore: update deps

* chore(snapshot): 17.3.0-snapshot.5

* fix(mojaloop/#3529): fix high latency  (#981)

* fix: upgrade central-services-stream library

* chore(snapshot): v17.2.1-snapshot.0

* chore(snapshot): 17.2.1-snapshot.1

* chore(snapshot): 17.2.1-snapshot.2

* chore(release): 17.2.1 [skip ci]

* feat(mojaloop/#3489): add negative integration tests (#975)

* chore: add support for unique transfers and dual currencies in batch

* check in for a negative test case

* uncommented tests

* added test for mixed currencies

* updated test for mixed currencies

* chore: dep and lint

---------

Co-authored-by: Kevin Leyow <[email protected]>

* Merge branch main of https://github.com/mojaloop/central-ledger into feature/position-prepare-binning

* chore: foreach to for loop

* chore: cleanup

* Update src/handlers/index.js

Co-authored-by: Miguel de Barros <[email protected]>

* chore: added readme doc

* fix: lint

* fix: unit tests

* fix: audit

* chore: cleanup

* fix(mojaloop/#3533): helm v15.2.0-rc fixes (#982)

fix(mojaloop/#3533): helm v15.2.0-rc fixes - mojaloop/project#3533

List of fixes:
- fix(mojaloop/#3580): missing toDestination on handling the fspiop source/destiation headers failing match validation on fulfil - regression on #2697 - v17.0.0...v17.2.0#diff-3a2d4aabbde0cd9517dd372f6ae6001ad607d005b5316785c8698fe25160aa92L393 - mojaloop/project#3580
    Fixes currently resolve regression failures on these tests:
        - p2p_money_transfer_put_notifications - payee receives no Notification with ABORTED status after sending invalid FSPIOP-Destination header with transferStatus=COMMITTED, file path: golden_path/bug fixes /Test for Bugfix #2697 - Central-Ledger Fulfil Handler does not correctly invalidate requests with an incorrect-non-existent FSP-ID in the FSPIOP-Destination header.json
        - p2p_money_transfer_patch_notifications - payee receives PATCH Notification with ABORTED status after sending invalid FSPIOP-Destination header with transferStatus=RESERVED, file path: golden_path/bug fixes/Test for Bugfix #2697 - Central-Ledger Fulfil Handler does not correctly invalidate requests with an incorrect-non-existent FSP-ID in the FSPIOP-Destination header.json

* chore(release): 17.3.0 [skip ci]

* chore: remove uuid4 (#976)

chore: remove uuid4
 - Remove uuid4 and use native randomUUID.
 - Bump some deps are quested by commit hook

* chore(release): 17.3.1 [skip ci]

* fix(mojaloop/#3615): upgrade dependencies (#985)

* chore(release): 17.3.2 [skip ci]

* fix: remove unneeded async/await

* feat: add validation for participantCurrencyIds / accountIds mapping

* chore: remove resolved TODOs

* test: Add test coverage

* chore: remove whitespaces

* fix: fixrebase  merge conflict

* chore: update dependencies

* doc: fix typo

* chore(snapshot): 17.4.0-snapshot.0

* chore(snapshot): 17.4.0-snapshot.1

* test: update unit tests

* chore(snapshot): 17.4.0-snapshot.2

* fix: route error callback for batch correctly

* chore(snapshot): 17.4.0-snapshot.3

* fix(batch): fix error callback message routing. update tests

* chore(snapshot): 17.4.0-snapshot.4

* fix(batch): fix message routing / properties for more error cases

* chore(snapshot): 17.4.0-snapshot.5

* test: update test coverage

* chore(snapshot): 17.4.0-snapshot.6

* fix: route bulk-prepare messages to non-batch prepare handler

* chore(snapshot): 17.4.0-snapshot.7

* doc: update comment

* chore: update deps. update README for batch.

* doc: Address TODO regarding participanLimits query optimization

* test: fix local integration testing

---------

Co-authored-by: Vijay <[email protected]>
Co-authored-by: Aarón Reynoza <[email protected]>
Co-authored-by: mojaloopci <[email protected]>
Co-authored-by: Sridevi Miriyala <[email protected]>
Co-authored-by: vijayg10 <[email protected]>
Co-authored-by: Miguel de Barros <[email protected]>
Co-authored-by: Marco Ippolito <[email protected]>
Co-authored-by: Steven Oderayi <[email protected]>
kleyow added a commit that referenced this pull request Dec 13, 2023
* feat: added skeleton and comments for prepare bin implementation

* chore: some changes

* feat: added new position handler v2

* feat: added some functionality to new position handler v2

* feat: added some todos

* feat: changed new handler name

* fix: lint

* feat: add some changes

* fix: lint

* chore: added copyright header

* feat: added some logic

* fix: lint

* feat: added unit tests

* feat: some improvements

* feat: added bin processor logic

* fix: lint

* feat; refactor

* feat: added limit

* fix: unit tests

* feat: added integration test

* feat: refactor

* fix: unit tests

* fix: integration tests

* feat: add position prepare bin logic (#970)

* feat: add position prepare bin logic

* edit

* lint

* dep

* chore: changes

* chore: commet

* lint

* chore: refactor

* chore: unit tests

* chore: change

* chore: comment

* chore: test

* chore: more test

* chore: test?

* chore: remove

* chore: rework domain logic

* chore: test

* fix: position calculation

* fix: position change data

* fix; prepare domain function

* chore: fix

---------

Co-authored-by: Vijay <[email protected]>

* chore: add tests (#972)

* chore: add tests

* chore: unit

* sleep

* chore: clear

* chore: test

* enum

* fix: deadlock in tests

---------

Co-authored-by: Vijay <[email protected]>

* fix: metrics

* fix: some issue with bin processor

* feat(mojaloop/#3489): add cached calls for participant currency, update tests (#973)

* chore: add tests

* chore: unit

* sleep

* chore: clear

* chore: test

* enum

* feat: add cached calls for participant currency

* chore: change

* chore: unit

* chore: unit

* lock

* test

* fix: unit test

---------

Co-authored-by: Vijay <[email protected]>

* chore: improve coverage and edit metric and query name (#974)

* chore: coverage

* lint

* chore: coverage

* more coverage

* chore: test

* chore: coverage

* chore: metric name

* chore: metric name

* chore: update query name

* chore: remove log

* chore(snapshot): 17.3.0-snapshot.0

* fix: test downgrade stream lib

* chore(snapshot): 17.3.0-snapshot.1

* fix: notification event action

* chore(snapshot): 17.3.0-snapshot.2

* fix: notification event

* chore(snapshot): 17.3.0-snapshot.3

* fix: notification messages

* chore(snapshot): 17.3.0-snapshot.4

* chore: updated conf

* chore: update deps

* chore(snapshot): 17.3.0-snapshot.5

* fix(mojaloop/#3529): fix high latency  (#981)

* fix: upgrade central-services-stream library

* chore(snapshot): v17.2.1-snapshot.0

* chore(snapshot): 17.2.1-snapshot.1

* chore(snapshot): 17.2.1-snapshot.2

* chore(release): 17.2.1 [skip ci]

* feat(mojaloop/#3489): add negative integration tests (#975)

* chore: add support for unique transfers and dual currencies in batch

* check in for a negative test case

* uncommented tests

* added test for mixed currencies

* updated test for mixed currencies

* chore: dep and lint

---------

Co-authored-by: Kevin Leyow <[email protected]>

* Merge branch main of https://github.com/mojaloop/central-ledger into feature/position-prepare-binning

* chore: foreach to for loop

* chore: cleanup

* Update src/handlers/index.js

Co-authored-by: Miguel de Barros <[email protected]>

* chore: added readme doc

* fix: lint

* fix: unit tests

* fix: audit

* chore: cleanup

* fix(mojaloop/#3533): helm v15.2.0-rc fixes (#982)

fix(mojaloop/#3533): helm v15.2.0-rc fixes - mojaloop/project#3533

List of fixes:
- fix(mojaloop/#3580): missing toDestination on handling the fspiop source/destiation headers failing match validation on fulfil - regression on #2697 - v17.0.0...v17.2.0#diff-3a2d4aabbde0cd9517dd372f6ae6001ad607d005b5316785c8698fe25160aa92L393 - mojaloop/project#3580
    Fixes currently resolve regression failures on these tests:
        - p2p_money_transfer_put_notifications - payee receives no Notification with ABORTED status after sending invalid FSPIOP-Destination header with transferStatus=COMMITTED, file path: golden_path/bug fixes /Test for Bugfix #2697 - Central-Ledger Fulfil Handler does not correctly invalidate requests with an incorrect-non-existent FSP-ID in the FSPIOP-Destination header.json
        - p2p_money_transfer_patch_notifications - payee receives PATCH Notification with ABORTED status after sending invalid FSPIOP-Destination header with transferStatus=RESERVED, file path: golden_path/bug fixes/Test for Bugfix #2697 - Central-Ledger Fulfil Handler does not correctly invalidate requests with an incorrect-non-existent FSP-ID in the FSPIOP-Destination header.json

* chore(release): 17.3.0 [skip ci]

* chore: remove uuid4 (#976)

chore: remove uuid4
 - Remove uuid4 and use native randomUUID.
 - Bump some deps are quested by commit hook

* chore(release): 17.3.1 [skip ci]

* fix(mojaloop/#3615): upgrade dependencies (#985)

* chore(release): 17.3.2 [skip ci]

* fix: remove unneeded async/await

* feat: add validation for participantCurrencyIds / accountIds mapping

* chore: remove resolved TODOs

* test: Add test coverage

* chore: remove whitespaces

* fix: fixrebase  merge conflict

* chore: update dependencies

* doc: fix typo

* chore(snapshot): 17.4.0-snapshot.0

* chore(snapshot): 17.4.0-snapshot.1

* test: update unit tests

* chore(snapshot): 17.4.0-snapshot.2

* fix: route error callback for batch correctly

* chore(snapshot): 17.4.0-snapshot.3

* fix(batch): fix error callback message routing. update tests

* chore(snapshot): 17.4.0-snapshot.4

* fix(batch): fix message routing / properties for more error cases

* chore(snapshot): 17.4.0-snapshot.5

* test: update test coverage

* chore(snapshot): 17.4.0-snapshot.6

* fix: route bulk-prepare messages to non-batch prepare handler

* chore(snapshot): 17.4.0-snapshot.7

* doc: update comment

* chore: update deps. update README for batch.

* doc: Address TODO regarding participanLimits query optimization

* stash

* chore: domain

* chore: test

* test

* chore: update bin processor tests

* chore: coverage

* log

* chore: update

* chore: up retries

* chore: test

* ci

* test

* install

* test

* test

* test

* script

* chore: fix order

* time

* test

* time

* time

* state

* time

* chore: check transfer state

* test

* lint

* chore: await

* address comments

* chore: dep

* chore: address comments

* coverage

* chore(snapshot): 17.5.0-snapshot.0

* remove

---------

Co-authored-by: Vijay <[email protected]>
Co-authored-by: Aarón Reynoza <[email protected]>
Co-authored-by: mojaloopci <[email protected]>
Co-authored-by: Sridevi Miriyala <[email protected]>
Co-authored-by: vijayg10 <[email protected]>
Co-authored-by: Miguel de Barros <[email protected]>
Co-authored-by: Marco Ippolito <[email protected]>
Co-authored-by: Steven Oderayi <[email protected]>
kleyow added a commit that referenced this pull request Dec 20, 2023
* feat: added skeleton and comments for prepare bin implementation

* chore: some changes

* feat: added new position handler v2

* feat: added some functionality to new position handler v2

* feat: added some todos

* feat: changed new handler name

* fix: lint

* feat: add some changes

* fix: lint

* chore: added copyright header

* feat: added some logic

* fix: lint

* feat: added unit tests

* feat: some improvements

* feat: added bin processor logic

* fix: lint

* feat; refactor

* feat: added limit

* fix: unit tests

* feat: added integration test

* feat: refactor

* fix: unit tests

* fix: integration tests

* feat: add position prepare bin logic (#970)

* feat: add position prepare bin logic

* edit

* lint

* dep

* chore: changes

* chore: commet

* lint

* chore: refactor

* chore: unit tests

* chore: change

* chore: comment

* chore: test

* chore: more test

* chore: test?

* chore: remove

* chore: rework domain logic

* chore: test

* fix: position calculation

* fix: position change data

* fix; prepare domain function

* chore: fix

---------

Co-authored-by: Vijay <[email protected]>

* chore: add tests (#972)

* chore: add tests

* chore: unit

* sleep

* chore: clear

* chore: test

* enum

* fix: deadlock in tests

---------

Co-authored-by: Vijay <[email protected]>

* fix: metrics

* fix: some issue with bin processor

* feat(mojaloop/#3489): add cached calls for participant currency, update tests (#973)

* chore: add tests

* chore: unit

* sleep

* chore: clear

* chore: test

* enum

* feat: add cached calls for participant currency

* chore: change

* chore: unit

* chore: unit

* lock

* test

* fix: unit test

---------

Co-authored-by: Vijay <[email protected]>

* chore: improve coverage and edit metric and query name (#974)

* chore: coverage

* lint

* chore: coverage

* more coverage

* chore: test

* chore: coverage

* chore: metric name

* chore: metric name

* chore: update query name

* chore: remove log

* chore(snapshot): 17.3.0-snapshot.0

* fix: test downgrade stream lib

* chore(snapshot): 17.3.0-snapshot.1

* fix: notification event action

* chore(snapshot): 17.3.0-snapshot.2

* fix: notification event

* chore(snapshot): 17.3.0-snapshot.3

* fix: notification messages

* chore(snapshot): 17.3.0-snapshot.4

* chore: updated conf

* chore: update deps

* chore(snapshot): 17.3.0-snapshot.5

* fix(mojaloop/#3529): fix high latency  (#981)

* fix: upgrade central-services-stream library

* chore(snapshot): v17.2.1-snapshot.0

* chore(snapshot): 17.2.1-snapshot.1

* chore(snapshot): 17.2.1-snapshot.2

* chore(release): 17.2.1 [skip ci]

* feat(mojaloop/#3489): add negative integration tests (#975)

* chore: add support for unique transfers and dual currencies in batch

* check in for a negative test case

* uncommented tests

* added test for mixed currencies

* updated test for mixed currencies

* chore: dep and lint

---------

Co-authored-by: Kevin Leyow <[email protected]>

* Merge branch main of https://github.com/mojaloop/central-ledger into feature/position-prepare-binning

* chore: foreach to for loop

* chore: cleanup

* Update src/handlers/index.js

Co-authored-by: Miguel de Barros <[email protected]>

* chore: added readme doc

* fix: lint

* fix: unit tests

* fix: audit

* chore: cleanup

* fix(mojaloop/#3533): helm v15.2.0-rc fixes (#982)

fix(mojaloop/#3533): helm v15.2.0-rc fixes - mojaloop/project#3533

List of fixes:
- fix(mojaloop/#3580): missing toDestination on handling the fspiop source/destiation headers failing match validation on fulfil - regression on #2697 - v17.0.0...v17.2.0#diff-3a2d4aabbde0cd9517dd372f6ae6001ad607d005b5316785c8698fe25160aa92L393 - mojaloop/project#3580
    Fixes currently resolve regression failures on these tests:
        - p2p_money_transfer_put_notifications - payee receives no Notification with ABORTED status after sending invalid FSPIOP-Destination header with transferStatus=COMMITTED, file path: golden_path/bug fixes /Test for Bugfix #2697 - Central-Ledger Fulfil Handler does not correctly invalidate requests with an incorrect-non-existent FSP-ID in the FSPIOP-Destination header.json
        - p2p_money_transfer_patch_notifications - payee receives PATCH Notification with ABORTED status after sending invalid FSPIOP-Destination header with transferStatus=RESERVED, file path: golden_path/bug fixes/Test for Bugfix #2697 - Central-Ledger Fulfil Handler does not correctly invalidate requests with an incorrect-non-existent FSP-ID in the FSPIOP-Destination header.json

* chore(release): 17.3.0 [skip ci]

* chore: remove uuid4 (#976)

chore: remove uuid4
 - Remove uuid4 and use native randomUUID.
 - Bump some deps are quested by commit hook

* chore(release): 17.3.1 [skip ci]

* fix(mojaloop/#3615): upgrade dependencies (#985)

* chore(release): 17.3.2 [skip ci]

* fix: remove unneeded async/await

* feat: add validation for participantCurrencyIds / accountIds mapping

* chore: remove resolved TODOs

* test: Add test coverage

* chore: remove whitespaces

* fix: fixrebase  merge conflict

* chore: update dependencies

* doc: fix typo

* chore(snapshot): 17.4.0-snapshot.0

* chore(snapshot): 17.4.0-snapshot.1

* test: update unit tests

* chore(snapshot): 17.4.0-snapshot.2

* fix: route error callback for batch correctly

* chore(snapshot): 17.4.0-snapshot.3

* fix(batch): fix error callback message routing. update tests

* chore(snapshot): 17.4.0-snapshot.4

* fix(batch): fix message routing / properties for more error cases

* chore(snapshot): 17.4.0-snapshot.5

* test: update test coverage

* chore(snapshot): 17.4.0-snapshot.6

* fix: route bulk-prepare messages to non-batch prepare handler

* chore(snapshot): 17.4.0-snapshot.7

* doc: update comment

* chore: update deps. update README for batch.

* doc: Address TODO regarding participanLimits query optimization

* stash

* chore: domain

* chore: test

* test

* chore: update bin processor tests

* chore: coverage

* log

* chore: update

* chore: up retries

* chore: test

* ci

* test

* install

* test

* test

* test

* script

* chore: fix order

* time

* test

* time

* time

* state

* time

* chore: check transfer state

* test

* lint

* chore: await

* address comments

* chore: dep

* chore: address comments

* coverage

* chore(snapshot): 17.5.0-snapshot.0

* feat: add reserve functionality

* int test

* remove

* name

* dep:check

---------

Co-authored-by: Vijay <[email protected]>
Co-authored-by: Aarón Reynoza <[email protected]>
Co-authored-by: mojaloopci <[email protected]>
Co-authored-by: Sridevi Miriyala <[email protected]>
Co-authored-by: vijayg10 <[email protected]>
Co-authored-by: Miguel de Barros <[email protected]>
Co-authored-by: Marco Ippolito <[email protected]>
Co-authored-by: Steven Oderayi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants