Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mojaloop/#3096): unable to upgrade knex dependency on centralLedger #939

Merged

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Jan 30, 2023

fix(mojaloop/#3096): unable to upgrade knex dependency on centralLedger - mojaloop/project#3096

  • added UV_THREADPOOL_SIZE config to CI command for running integration tests
  • upgraded knex to latest version

The following issue mojaloop/project#3112 was created to investigate as to why the Integration Tests are so unstable when then Event Handlers are executing in-line. For the time being the above PR clearly separates the process which resolves the stability issue for the time being.

The following changes were made as a work-around:

  • Integration Tests will no longer start the Event Handlers in-line. You will need to start the Central-Ledger Service as a seperate process (see updated documentation for more information)
  • Documentation for Integration Tests updated to reflect the above requirement
  • CI Job updated to start the Central-Ledger Service as a seperate Process prior to running Integration Tests
  • Added comments to where the commented out code for the initialization of the in-line Event Handlers referencing the above story.
  • Also made some changes to the Handler tests to handle failures instead of stalling the Integration Tests

chore: maintenance updates

  • fixed audit issues
  • added missing kafka topics from docker-compose init kafka container to ensure the CL Service startup is clean

…er - mojaloop/project#3096

- added UV_THREADPOOL_SIZE config to circleci command for running integration tests
- upgraded knex to latest version
…ervice running in the background for integration tests to run against

- updated handlers.test to NOT startup handlers
- updated CI config to start central-ledger independantly before running integration tests
@mdebarros mdebarros self-assigned this Feb 3, 2023
@mdebarros mdebarros marked this pull request as ready for review February 3, 2023 13:13
@mdebarros mdebarros merged commit c376af8 into master Feb 3, 2023
@mdebarros mdebarros deleted the fix/#3096-Unable-to-upgrade-Knex-dependency-on-Central-Ledger branch February 3, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants