-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mojaloop/#3096): unable to upgrade knex dependency on centralLedger #939
Merged
mdebarros
merged 38 commits into
master
from
fix/#3096-Unable-to-upgrade-Knex-dependency-on-Central-Ledger
Feb 3, 2023
Merged
fix(mojaloop/#3096): unable to upgrade knex dependency on centralLedger #939
mdebarros
merged 38 commits into
master
from
fix/#3096-Unable-to-upgrade-Knex-dependency-on-Central-Ledger
Feb 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er - mojaloop/project#3096 - added UV_THREADPOOL_SIZE config to circleci command for running integration tests - upgraded knex to latest version
…ervice running in the background for integration tests to run against - updated handlers.test to NOT startup handlers - updated CI config to start central-ledger independantly before running integration tests
mdebarros
requested review from
elnyry-sam-k,
vijayg10 and
kleyow
as code owners
February 3, 2023 13:13
kleyow
approved these changes
Feb 3, 2023
mdebarros
deleted the
fix/#3096-Unable-to-upgrade-Knex-dependency-on-Central-Ledger
branch
February 3, 2023 13:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(mojaloop/#3096): unable to upgrade knex dependency on centralLedger - mojaloop/project#3096
The following issue mojaloop/project#3112 was created to investigate as to why the Integration Tests are so unstable when then Event Handlers are executing in-line. For the time being the above PR clearly separates the process which resolves the stability issue for the time being.
The following changes were made as a work-around:
chore: maintenance updates