-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mojaloop/#3024): post /bulkTransfers from Switch to PayeeFSP to use Switch as fspiop-source #926
Merged
mdebarros
merged 8 commits into
master
from
feat/#3024-post-bulkTransfers-from-Switch-to-PayeeFSP-to-use-Switch-as-fspiop-source
Nov 21, 2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ayeeFSP to use Switch as fspiop-source fix(mojaloop/#3024): [core bulk] POST /bulkTransfers from Switch to PayeeFSP to use Switch as fspiop-source - mojaloop/project#3024 - updated fulfil-handler to only check headers on non-bulk actions - updated bulk-fulfil-handler validation to also accept "switch" as a valid DESTINATION header
mdebarros
requested review from
elnyry-sam-k,
vijayg10 and
kleyow
as code owners
November 18, 2022 11:31
This was referenced Nov 18, 2022
mdebarros
changed the title
fix(mojaloop/#3024): [core bulk] POST /bulkTransfers from Switch to PayeeFSP to use Switch as fspiop-source
fix(mojaloop/#3024): post /bulkTransfers from Switch to PayeeFSP to use Switch as fspiop-source
Nov 18, 2022
elnyry-sam-k
previously approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Miguel, looks good; just a couple of minor suggestions on the comments..
Co-authored-by: Sam <[email protected]>
Co-authored-by: Sam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment.. please review
Co-authored-by: Sam <[email protected]>
elnyry-sam-k
approved these changes
Nov 21, 2022
mdebarros
deleted the
feat/#3024-post-bulkTransfers-from-Switch-to-PayeeFSP-to-use-Switch-as-fspiop-source
branch
November 21, 2022 13:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(mojaloop/#3024): [core bulk] POST /bulkTransfers from Switch to PayeeFSP to use Switch as fspiop-source - mojaloop/project#3024
Related PRs: