refactor!: rework bulk handler validation #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleyow
changed the title
kleyow
requested review from
vgenev,
mdebarros,
elnyry-sam-k,
lewisdaly,
oderayi,
shashi165 and
vijayg10
as code owners
elnyry-sam-k
reviewed
Aug 5, 2022
elnyry-sam-k
reviewed
Aug 5, 2022
elnyry-sam-k
reviewed
Aug 5, 2022
elnyry-sam-k
reviewed
Aug 5, 2022
elnyry-sam-k
reviewed
Aug 5, 2022
elnyry-sam-k
reviewed
Aug 5, 2022
|
Thanks Kevin, looks good.. just some suggestions on changes to error descriptions / messages.. Nice to capture additional errors as information in extension lists and adding new (specific) validation errors.. |
|
@elnyry-sam-k done |
elnyry-sam-k
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework bulk handler validator
reasonsstring array to aFSPIOPErrorarray to better specify error codes and descriptions.Follow up PR for mojaloop/project#2800 mojaloop/project#2798
Test cases updated here mojaloop/testing-toolkit-test-cases#79
Breaking changes:
The FSPIOP api errors for invalid/inactive/non-existant FSP's for Bulk Transfers are now updated to be more descriptive.
They have been updated to
If you have conditional logic based on error callbacks of POST /bulkTransfers you will need to update the error codes accordingly.