Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/#2092): upgrade nodeJS version for core services #902

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented May 24, 2022

feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092

  • standardised CI scripts, however, the test-integration CI job needed minor tweaks to work with the central-ledger's implementation
  • updated docker-compose files to work correctly
  • added wait-4-docker npm script
  • fixed lint issues
  • updated .nvmrc to latest LTS version
  • added standard CI scripts/config to package.json: release, snapshot, standard-version, etc
  • updated gitignore to include test/results and IGNORE patterns
  • updated README with standard auto-release information
  • Fixed imports
  • Cleaned up Package.json
  • Removed unnecessary dependencies
  • Removed unnecessary files
  • Re-factored some integration test wrapWithRetries functions to cater for the expected return value, this will mean that integration tests should be more consistent and be more resilient to time-processing issues.
  • Added a slight bump to the wrapWithRetries test helper function's default params for retries, and timeout

Notes:

  • 'get-port' dependency version is fixed to v5.1.1, this is because v9+ only supports ESM loaders and not CJS. This will need to be addressed in a future story.
  • Helm chart mountPaths need to be updated from /opt/central-ledger to /opt/app as follows:
        volumeMounts:
        - mountPath: /opt/app/config
          name: <deployment-name>

BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses /opt/app instead of /opt/central-ledger which will impact config mounts.

feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092
- standardised CI scripts
- fixed lint issues
- updated .nvmrc to latest LTS version
- added standard CI scripts/config to package.json: release, snapshot, standard-version, etc
- updated gitignore to include test/results and IGNORE patterns
- updated README with standard auto-release information
- Fixed imports
- Cleaned up Package.json
- Removed unnecessary dependencies
- Removed unecessary files

- 'get-port' dependency version is fixed to v5.1.1, this is because v9+ only supports ESM loaders and not CJS. This will need to be addressed in a future story.
- Helm chart mountPaths need to be updated from `/opt/central-ledger` to `/opt/app` as follows:
    ```YAML
        volumeMounts:
        - mountPath: /opt/app/config
          name: <deployment-name>
    ```

BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses `/opt/app` instead of `/opt/central-ledger` which will impact config mounts.
@mdebarros mdebarros marked this pull request as ready for review May 26, 2022 11:34
@mdebarros mdebarros self-assigned this May 26, 2022
@mdebarros mdebarros merged commit defff30 into mojaloop:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants