-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mojaloop/#2092): upgrade nodeJS version for core services #902
Merged
mdebarros
merged 21 commits into
mojaloop:master
from
mdebarros:feat/#2092-Upgrade-NodeJS-Version-for-core-services
May 26, 2022
Merged
feat(mojaloop/#2092): upgrade nodeJS version for core services #902
mdebarros
merged 21 commits into
mojaloop:master
from
mdebarros:feat/#2092-Upgrade-NodeJS-Version-for-core-services
May 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092 - standardised CI scripts - fixed lint issues - updated .nvmrc to latest LTS version - added standard CI scripts/config to package.json: release, snapshot, standard-version, etc - updated gitignore to include test/results and IGNORE patterns - updated README with standard auto-release information - Fixed imports - Cleaned up Package.json - Removed unnecessary dependencies - Removed unecessary files - 'get-port' dependency version is fixed to v5.1.1, this is because v9+ only supports ESM loaders and not CJS. This will need to be addressed in a future story. - Helm chart mountPaths need to be updated from `/opt/central-ledger` to `/opt/app` as follows: ```YAML volumeMounts: - mountPath: /opt/app/config name: <deployment-name> ``` BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses `/opt/app` instead of `/opt/central-ledger` which will impact config mounts.
12 tasks
…r does not have any, also renamed re-factored test:int npm script to align to standards
mdebarros
requested review from
vgenev,
elnyry-sam-k,
lewisdaly,
oderayi,
shashi165 and
vijayg10
as code owners
May 26, 2022 11:34
…ed deprecated files for the integration-runner which is no longer necessary
elnyry-sam-k
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092
wrapWithRetries
functions to cater for the expected return value, this will mean that integration tests should be more consistent and be more resilient to time-processing issues.wrapWithRetries
test helper function's default params for retries, and timeoutNotes:
/opt/central-ledger
to/opt/app
as follows:BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses
/opt/app
instead of/opt/central-ledger
which will impact config mounts.