Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morgan Fingerprint #72

Open
CaiYitao opened this issue Apr 9, 2022 · 4 comments
Open

Morgan Fingerprint #72

CaiYitao opened this issue Apr 9, 2022 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@CaiYitao
Copy link

CaiYitao commented Apr 9, 2022

Is there a function which is similar to the following rdkit morgan fingerprint

fp_vec = AllChem.GetMorganFingerprintAsBitVect(mol, radius=3, nBits=fp_length)

and convert it to array

DataStructs.ConvertToNumpyArray(fp_vec, arr)

Thank you!

@mojaie
Copy link
Owner

mojaie commented Apr 9, 2022

Thank you for your comment.
Unfortunately, Morgan fingerprint is not implemented yet.

@mojaie mojaie added the help wanted Extra attention is needed label Apr 9, 2022
@Nick-Mul
Copy link

I am quite new to Julia and but like this project. I was looking for something similar but a encode the molecular graph as a vector. I was going to try to covert this python example in Julia but it occurs to me most of this is already implemented here?! https://www.blopig.com/blog/2022/02/how-to-turn-a-smiles-string-into-a-molecular-graph-for-pytorch-geometric/

@mojaie
Copy link
Owner

mojaie commented Jun 27, 2022

Thank you for your interest.
Maybe MolecularGraph.jl functionality corresponds to step 1, 2 and middle of step 3 of the tutorial article you mentioned.

Please refer the following tutorial
https://github.com/mojaie/MolecularGraph.jl_notebook

Building molecular objects like RDKit Chem.MolFromSmiles is demonstrated below

Getting started
https://nbviewer.org/github/mojaie/MolecularGraph.jl_notebook/blob/master/notebook/gettingStarted.ipynb

get_atom_features and get_atom_features may correspond to below, but the definition of molecular features may be a little different (maybe have improved) from RDKit

Calculate descriptors
https://nbviewer.org/github/mojaie/MolecularGraph.jl_notebook/blob/master/notebook/calculateDescriptors.ipynb

feature vectorization (latter half of step 3 of the tutorial) for linear algebra-based machine learning is not available (this is not my scope, maybe will not be implemented here, but I believe MolecularGraph.jl has good interfaces to build and customize feature vectors).

I'm sorry that the development of MolecularGraph.jl is not so active now due to my busy schedule, so tutorials are maybe not up to date.

@Nick-Mul
Copy link

Thank you for the pointers. You've done a great job on this project so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants