Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a fallback for sampled sounds: play with oscillator #72

Closed
bwl21 opened this issue Jan 13, 2018 · 5 comments
Closed

Provide a fallback for sampled sounds: play with oscillator #72

bwl21 opened this issue Jan 13, 2018 · 5 comments

Comments

@bwl21
Copy link
Contributor

bwl21 commented Jan 13, 2018

Request

could we have a fallback to oscillator sounds (not using samples), because

  • we sometimes have problems running the sampled sounds (Player does not work on Safari #71).
  • When using on slow network connection, downloading the samples might take long.
  • For trivial applications, an oscillator sound might be enough

proposal

control by soundfont type "osc"
provide the timbre as another property in the configuration object

@moinejf
Copy link
Owner

moinejf commented Jan 13, 2018

I already removed this feature which does not work fine in FireFox.
If you need it, you may code it yourself replacing toaudio5.js.

@bwl21
Copy link
Contributor Author

bwl21 commented Jan 13, 2018

Firefox Quantum is a vast improvement. It now plays the oscillator sounds very well. And some of my users complained about the sampled sounds ...

I would not replace toaudio5.js but implement an additional class which I could select in AbcPlay to implement the fallback.

Do you still have the code which you removed before?

@bwl21
Copy link
Contributor Author

bwl21 commented Mar 26, 2018

Not sure If I still need this as the player is getting better with 1.16 ...

But If, wouldn't it be sufficient to replace load_res() and note_run() accordingly?

@moinejf
Copy link
Owner

moinejf commented Mar 26, 2018

I don't see what you mean.
toaudio5 is a way the play the notes using the web audio API. You may replace it with anything else, as using the html5 MIDI interface and connect a MIDI synthesizer (I have it in vivaldi), or convert the notes to csound commands and pipe them via a HTTP server. There are a lot of ways to produce sound.

@bwl21
Copy link
Contributor Author

bwl21 commented Mar 26, 2018

My intention was, to use as much as possible from toaudio5 (in particular the timing) but use an osscilaator instead of a soundfont. But as I said, the player is getting better with 1.16, so i close this ticket for the time being.

@bwl21 bwl21 closed this as completed Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants