Change from -m <mode> syntax to <verb>, update gitignore #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you!
I believe that requires some GUI changes, I will implement that soon. |
It should just be adding 3 checkboxes to the GUI that append the correct arguments to the command string. I put an example on disabling per-service 3rd party emotes in the CLI documentation |
|
|
|
This is now safe to be merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very soon TwitchDownloaderCLI will switch from
./TwitchDownloaderCLI -m <mode>to./TwitchDownloaderCLI <verb>. While the-msyntax will still work, it prints a warning message which you likely won't want showing to users. So only when the latest release is greater than 1.50.6 merge this.Also added
.vsfolder to gitignoreWish I could help more with this project, like adding per-service emote embedding, but I don't know enough C