[mojo-stdlib] Add list.insert(index, value) API to stdlib #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neroro64
reviewed
Apr 2, 2024
arthurevans
reviewed
Apr 3, 2024
whym1here
force-pushed
the
mojo-list-insert
branch
from
1b54502 to
e4634b5
Compare
JoeLoser
reviewed
Apr 6, 2024
There was a problem hiding this comment.
Looks good! We'll need to rebase this PR/resolve conflicts and then add a test for the negative index case.
Currently, the PR is showing many commits from April 4th that already exist in the nightly branch. If you use git rebase -i upstream/nightly where upstream is the corresponding git remote:
git remote -v
upstream [email protected]:modularml/mojo.git (fetch)
upstream [email protected]:modularml/mojo.git (push)
then you'll be able to see those commits not show up as duplicates in your PR. Please let me know if you run into any issues and I'll be happy to help.
whym1here
force-pushed
the
mojo-list-insert
branch
2 times, most recently
from
c97ff8c to
9e29bdf
Compare
whym1here
force-pushed
the
mojo-list-insert
branch
from
7f5a393 to
528c276
Compare
|
Looks like CI is failing due to formatting. Do you mind running |
JoeLoser
approved these changes
Apr 9, 2024
| assert_equal(vec[1], 2) | ||
| assert_equal(vec[2], 3) | ||
|
|
||
| vec.clear() |
There was a problem hiding this comment.
Suggestion Instead of manually running clear() between the different parts of this function, it would read better to just use different variables, such as v1 = List[Int](), v2 = List[Int](), and so on. What do you think?
Signed-off-by: Dhaval Kumar <[email protected]>
Signed-off-by: Dhaval Kumar <[email protected]>
Signed-off-by: Dhaval Kumar <[email protected]>
Signed-off-by: Dhaval Kumar <[email protected]>
Signed-off-by: Dhaval Kumar <[email protected]>
whym1here
force-pushed
the
mojo-list-insert
branch
from
528c276 to
a3365d3
Compare
1 task
arvindavoudi
pushed a commit
to arvindavoudi/mojo
that referenced
this pull request
Apr 13, 2024
Add `List.insert(index, value)` API as requested in modular#2134. This API should handle the same functionality as the Python `list.insert` and adds tests for the same. Fixes modular#2134 Signed-off-by: Dhaval Kumar <[email protected]>
patrickdoc
added a commit
to patrickdoc/mojo
that referenced
this pull request
Apr 24, 2024
…odular#2148) (#38047) Add `List.insert(index, value)` API as requested in [Internal Link] This API should handle the same functionality as the Python `list.insert` and adds tests for the same. Fixes [Internal Link] Signed-off-by: Dhaval Kumar <[email protected]> mojo-orig-commit: 98e062d modular-orig-commit: 5128d9ad94ee7acb9b876d3738e7ce47405afdab
jayzhan211
pushed a commit
to jayzhan211/mojo
that referenced
this pull request
Apr 27, 2024
…odular#2148) (#38047) Add `List.insert(index, value)` API as requested in [Internal Link] This API should handle the same functionality as the Python `list.insert` and adds tests for the same. Fixes [Internal Link] Signed-off-by: Dhaval Kumar <[email protected]> mojo-orig-commit: 98e062d modular-orig-commit: 5128d9ad94ee7acb9b876d3738e7ce47405afdab
patrickdoc
added a commit
to patrickdoc/mojo
that referenced
this pull request
May 2, 2024
…odular#2148) (#38047) Add `List.insert(index, value)` API as requested in modular#2134. This API should handle the same functionality as the Python `list.insert` and adds tests for the same. Fixes modular#2134 Signed-off-by: Dhaval Kumar <[email protected]> mojo-orig-commit: 98e062d MODULAR_ORIG_COMMIT_REV_ID: 5128d9ad94ee7acb9b876d3738e7ce47405afdab
patrickdoc
added a commit
that referenced
this pull request
May 2, 2024
…2148) (#38047) Add `List.insert(index, value)` API as requested in #2134. This API should handle the same functionality as the Python `list.insert` and adds tests for the same. Fixes #2134 Signed-off-by: Dhaval Kumar <[email protected]> mojo-orig-commit: 98e062d MODULAR_ORIG_COMMIT_REV_ID: 5128d9ad94ee7acb9b876d3738e7ce47405afdab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr serves to add
list.insert(index, value)API to the stdlib as requested by issue #2134.This API should handle the same functionality as the python
list.insertand adds tests for the same.