Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct return codes #21

Open
joshuahannan opened this issue Apr 25, 2018 · 0 comments
Open

correct return codes #21

joshuahannan opened this issue Apr 25, 2018 · 0 comments

Comments

@joshuahannan
Copy link

The repository’s wallet documentation states that the confirm and revoke functions return true if the transaction is successful. The function confirmTx does not return true upon a final confirmation, which triggers an execution of the transaction. Consider returning true right after the require statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant