Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate owners can exist #19

Open
joshuahannan opened this issue Apr 25, 2018 · 0 comments
Open

Duplicate owners can exist #19

joshuahannan opened this issue Apr 25, 2018 · 0 comments

Comments

@joshuahannan
Copy link

Despite WalletAdminLib’s changeOwner and addOwner functions checking that the incoming owner does not already exist, WalletMainLib does not perform such a check in its init function. A wallet with duplicate owners could result in unexpected behavior.
Consider using require(ownerIndex[_owners[i]] == 0) inside the loop that iterates through the incoming owner array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant