Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some members of the Transaction struct are never used #15

Open
joshuahannan opened this issue Apr 25, 2018 · 0 comments
Open

Some members of the Transaction struct are never used #15

joshuahannan opened this issue Apr 25, 2018 · 0 comments

Comments

@joshuahannan
Copy link

When a Transaction is created, it’s confirmRequired and day members are set. When a transaction is confirmed, it’s confirmedOwners and confirmCount members are updated. When a transaction is considered for execution, it’s data member is populated. Finally, when a transaction is executed, it’s success member is set to true. However, it’s value and amount members are never used.
An owner querying a transaction for approval could still obtain, or at least verify a transaction’s associated value. This could be achieved with WalletMainLib’s getAmount function to extract the amount involved in a token transaction and, if a transaction is known to be a transfer of ether (and the amount of ether is known, as well as the destination address receiving the ether), the id of the transaction could be used to confirm a hypothetical ether value. Both of these are rather cumbersome and technically demanding.
Consider populating the members value and amount upon Transaction creation, or removing these members from the struct altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant