Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-zero based column output from mfdis.get_lrc() #1040

Closed
phaehnel opened this issue Jan 19, 2021 · 2 comments
Closed

Non-zero based column output from mfdis.get_lrc() #1040

phaehnel opened this issue Jan 19, 2021 · 2 comments

Comments

@phaehnel
Copy link

phaehnel commented Jan 19, 2021 •
edited
Loading

Hi there,

during my current work with flopy 3.3.2 I ran into the problem that the mfdis.get_lrc() method does return layer and row information with zero base (for first layer and row of the model) but the output for columns starts with 1.
Could that be caused by line 577 in the mfdis.py script:
line 577: v.append((k - 1, i - 1, j))
causing j to be handed back in line 578 instead of j-1?

Greetings,
Patrick
@phaehnel phaehnel changed the title Non-zero based column output from mfdis.get_lcr() Non-zero based column output from mfdis.get_lrc() Jan 19, 2021
@langevin-usgs
Copy link
Contributor

Yes, this is a problem, as also indicated here: 52ecd98#commitcomment-46556384. Will try to get this fixed for next release.

langevin-usgs referenced this issue Jan 30, 2021
@jlarsen-usgs
Fix(ModflowDis): zero based get_node() and get_lrc()… (#847)
52ecd98 
* Fix(ModflowDis): zero based get_node() and get_lrc() for input parameters and output

* added test_get_lrc_get_node()
@langevin-usgs
Copy link
Contributor

This should be fixed with #1049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@langevin-usgs @phaehnel