Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-runner] Empty browser list crashes with unfriendly message #614

Closed
aomarks opened this issue Sep 22, 2020 · 0 comments · Fixed by #671
Closed

[test-runner] Empty browser list crashes with unfriendly message #614

aomarks opened this issue Sep 22, 2020 · 0 comments · Fixed by #671
Labels
enhancement New feature or request

Comments

@aomarks
Copy link
Contributor

aomarks commented Sep 22, 2020

Extremely low priority, just noticed that setting browsers to an empty array in the config file shows this slightly unfriendly error:

(node:34995) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'length' of undefined
    at Object.getTestProgressReport (/Users/aomarks/code/lit-html/packages/tests/node_modules/@web/test-runner-cli/dist/reporter/getTestProgress.js:75:73)
    at Object.getTestProgress (/Users/aomarks/code/lit-html/packages/tests/node_modules/@web/test-runner-cli/dist/reporter/defaultReporter.js:49:38)
    at TestRunnerCli.reportTestProgress (/Users/aomarks/code/lit-html/packages/tests/node_modules/@web/test-runner-cli/dist/cli/TestRunnerCli.js:265:100)
    at TestRunnerCli.start (/Users/aomarks/code/lit-html/packages/tests/node_modules/@web/test-runner-cli/dist/cli/TestRunnerCli.js:65:14)
    at Object.startTestRunner (/Users/aomarks/code/lit-html/packages/tests/node_modules/@web/test-runner-cli/dist/startTestRunner.js:38:9)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:34995) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:34995) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.```
@LarsDenBakker LarsDenBakker added the enhancement New feature or request label Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants