-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in contract verification from 0.45.0 to 0.46.0 #3035
Labels
[C] Bug
This is a bug. Something isn't working.
Comments
9 tasks
feliperodri
added a commit
to feliperodri/kani
that referenced
this issue
Feb 28, 2024
Fixes model-checking#3035 Signed-off-by: Felipe R. Monteiro <[email protected]>
feliperodri
added a commit
to feliperodri/kani
that referenced
this issue
Feb 28, 2024
Fixes model-checking#3035 Signed-off-by: Felipe R. Monteiro <[email protected]>
feliperodri
added a commit
to feliperodri/kani
that referenced
this issue
Feb 29, 2024
Fixes model-checking#3035 Signed-off-by: Felipe R. Monteiro <[email protected]>
feliperodri
added a commit
that referenced
this issue
Mar 2, 2024
Fixes #3035. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Signed-off-by: Felipe R. Monteiro <[email protected]>
roypat
added a commit
to roypat/firecracker
that referenced
this issue
Mar 19, 2024
Remove the pin of kani to 0.45.0. We introduced this pin in 2f01981 due to model-checking/kani#3035. Kani fixed the issue in 0.48.0 (verifier by installing kani 0.48.0 locally and executing the gcd proof), so we can remove the pin and pick up a new kani version the next time we rebuild the docker container. Signed-off-by: Patrick Roy <[email protected]>
9 tasks
zulinx86
pushed a commit
to firecracker-microvm/firecracker
that referenced
this issue
Mar 21, 2024
Remove the pin of kani to 0.45.0. We introduced this pin in 2f01981 due to model-checking/kani#3035. Kani fixed the issue in 0.48.0 (verifier by installing kani 0.48.0 locally and executing the gcd proof), so we can remove the pin and pick up a new kani version the next time we rebuild the docker container. Signed-off-by: Patrick Roy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While upgrading the kani version used in Firecracker's CI to 0.46.0 I started noticing one of our harnesses started to fail with a failure that should have been ruled out by the contract's
requires
clause ("Failed Checks: x > 0 && y > 0", see https://buildkite.com/firecracker/firecracker-pr/builds/9140#018dc0ef-ba26-42b3-8b0f-124c00dad946 for the verification failure).I was able to minimize the example to the following:
using the following command line invocation:
with Kani version:
I expected to see this happen: The verification passes with kani 0.45.0 (both the firecracker example, and the minimal reproducer), so I was expecting it to also pass in 0.46.0 (although the interesting thing is that 0.45.0 only has 20 checks, while 0.46.0 has over 1000, so maybe there was something wrong in 0.45.0 that got fixed in 0.46.0?)
Instead, this happened: Verification failed (output: https://pastebin.com/EDUN0TVq, sorry it was too long for a github comment :( )
The text was updated successfully, but these errors were encountered: