Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assess requires user to pass --legacy-linker #1796

Closed
celinval opened this issue Oct 24, 2022 · 0 comments · Fixed by #1816
Closed

Assess requires user to pass --legacy-linker #1796

celinval opened this issue Oct 24, 2022 · 0 comments · Fixed by #1816
Assignees
Labels
[C] Bug This is a bug. Something isn't working.

Comments

@celinval
Copy link
Contributor

I tried the code from this workspace: https://github.com/model-checking/kani/tree/main/tests/cargo-ui/ws-integ-tests

using the following command line invocation:

cargo kani assess

with Kani version: 0.13

I expected to see this happen: I expected Kani to return some useful information.

Instead, this happened: The tables are basically empty:

Results:
Analyzed 4 crates
============================================
 Unsupported feature |   Crates | Instances 
                     | impacted |    of use 
---------------------+----------+-----------
 caller_location     |        4 |         4 
============================================
======================================
 Reason for failure | Number of tests 
--------------------+-----------------
======================================
========================================
 Candidate for proof harness | Location 
-----------------------------+----------
========================================

Adding --legacy-linker argument, returns more information.

Results:
Analyzed 9 crates
No crates contained Rust features unsupported by Kani
Checking harness test_no_overflow::{closure#0}...
Checking harness test_no_overflow::{closure#0}...

VERIFICATION RESULT:
 ** 1 of 190 failed (189 undetermined)
Failed Checks: unwinding assertion loop 1
 File: "/rustlib/src/rust/library/core/src/tuple.rs", line 31, in core::tuple::<impl std::cmp::PartialEq for (u8, bool)>::eq

VERIFICATION:- FAILED
[Kani] info: Verification output shows one or more unwinding failures.
[Kani] tip: Consider increasing the unwinding value or disabling `--unwinding-assertions`.
Verification Time: 0.18894474s


VERIFICATION RESULT:
 ** 1 of 190 failed (189 undetermined)
Failed Checks: unwinding assertion loop 1
 File: "rustlib/src/rust/library/core/src/tuple.rs", line 31, in core::tuple::<impl std::cmp::PartialEq for (u8, bool)>::eq

VERIFICATION:- FAILED
[Kani] info: Verification output shows one or more unwinding failures.
[Kani] tip: Consider increasing the unwinding value or disabling `--unwinding-assertions`.
Verification Time: 0.1891987s

======================================
 Reason for failure | Number of tests 
--------------------+-----------------
 unwind             |               2 
======================================
========================================
 Candidate for proof harness | Location 
-----------------------------+----------
========================================

The issue is due to the usage of the MIR Linker which by default performs reachability starting from a harnesses. The assess feature should be using the pub_fns reachability option described here.

@celinval celinval added the [C] Bug This is a bug. Something isn't working. label Oct 24, 2022
@celinval celinval added this to the Create Kani Assess tool milestone Oct 24, 2022
@tedinski tedinski self-assigned this Oct 24, 2022
@rahulku rahulku moved this to In Progress in Kani 0.14 Nov 1, 2022
Repository owner moved this from In Progress to Done in Kani 0.14 Nov 1, 2022
@tedinski tedinski moved this to Done in Kani 0.15 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] Bug This is a bug. Something isn't working.
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants