You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In codegen_rvalue we used to handle two kinds of Rvalue::Cast: CastKind::Misc and CastKind::Pointer
Rust introduced in a couple PRs new variants that distinguish (from CastKind::Misc) casts that turn pointers into numbers or vice versa. This is likely due to the need to think specially about these, since they need to invent (or forget) pointer providence.
We currently do not take advantage of this. Should we?
I believe this got further broken out in a later rust toolchain update, and CastKind:Misc no longer exists, in favor of recording explicit kinds for everything. I don't think there's anything special to do here anymore. If we should be handling this differently, it'd be a different issue to support a specific aim.
In
codegen_rvalue
we used to handle two kinds ofRvalue::Cast
:CastKind::Misc
andCastKind::Pointer
Rust introduced in a couple PRs new variants that distinguish (from
CastKind::Misc
) casts that turn pointers into numbers or vice versa. This is likely due to the need to think specially about these, since they need to invent (or forget) pointer providence.We currently do not take advantage of this. Should we?
Rust PRs:
The text was updated successfully, but these errors were encountered: