Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"watch" functionality needs tests #3270

Closed
boneskull opened this issue Mar 7, 2018 · 4 comments
Closed

"watch" functionality needs tests #3270

boneskull opened this issue Mar 7, 2018 · 4 comments
Labels
status: accepting prs Mocha can use your help with this one!

Comments

@boneskull
Copy link
Contributor

We have no integration tests around the "watch" functionality (see #3265).

Why? Because it's a pain. You'd have to run a test against some files, then modify a file from the test, then manually kill the child process and assert its output is as expected. Normally we like to use the JSON reporter internally, but this test won't print a single JSON file to STDOUT like the others--it would return multiple files to STDOUT. So we'll have to split up the output and make assertions on both.
@boneskull boneskull added status: accepting prs Mocha can use your help with this one! qa labels Mar 7, 2018
@boneskull
Copy link
Contributor Author

A good place to start might just be "run a test with --watch enabled, kill the child process, and assert the output is correct"

@boneskull
Copy link
Contributor Author

cc @outsideris, for context

@outsideris
Copy link
Contributor

I agreed with you on integration tests.

@craigtaub craigtaub mentioned this issue May 8, 2018
Merged
@outsideris
Copy link
Contributor

Closed by #3379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Mocha can use your help with this one!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@outsideris @boneskull