Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove special cases around unsupported Node.js versions #3029

Closed
boneskull opened this issue Sep 28, 2017 · 5 comments
Closed

remove special cases around unsupported Node.js versions #3029

boneskull opened this issue Sep 28, 2017 · 5 comments
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.

Comments

@boneskull
Copy link
Contributor

@ScottFreeCode I think basically we're looking at reverting 8710438, but also if you see anything else in the code please zap that nasty
@boneskull boneskull added the type: chore generally involving deps, tooling, configuration, etc. label Sep 28, 2017
@boneskull boneskull added this to the v4.0.0 milestone Sep 28, 2017
@boneskull
Copy link
Contributor Author

please remove lib/to-iso-string; we don't need it any longer

@boneskull
Copy link
Contributor Author

this is probably going to be an ongoing process... I've zapped some (shims) anyway.

@boneskull boneskull removed this from the v4.0.0 milestone Sep 30, 2017
@boneskull boneskull added the status: accepting prs Mocha can use your help with this one! label Oct 2, 2017
@boneskull
Copy link
Contributor Author

Not sure if there are any still hanging around; think I got most of them.

@boneskull
Copy link
Contributor Author

If anyone wants to help here, please see that there's nothing weird leftover.

The only thing that is held back currently is the buffer package, which stays at ^4.0.0 for IE10 support.

@boneskull boneskull added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Oct 4, 2017
@snyk-bot snyk-bot mentioned this issue Jan 22, 2020
Open
@juergba juergba removed the status: accepting prs Mocha can use your help with this one! label Jan 26, 2020
@juergba
Copy link
Contributor

juergba commented Jan 26, 2020

The only thing that is held back currently is the buffer package, which stays at ^4.0.0 for IE10 support.

Removed long time ago => closing this PR.

@juergba juergba closed this as completed Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@boneskull @ScottFreeCode @juergba