Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better scoping for css rules #1842

Closed
dasilvacontin opened this issue Aug 22, 2015 · 0 comments
Closed

better scoping for css rules #1842

dasilvacontin opened this issue Aug 22, 2015 · 0 comments
Labels
area: browser browser-specific

Comments

@dasilvacontin
Copy link
Contributor

It's easy for mocha browser elements to inherit undesired css rules. Just look at those class names.. .progress...

Quoting @irnc at #1827 (comment):

In order to prevent such conflicts from happening, it is a good idea to avoid nesting in mochas CSS, e.g. by adapting BEM naming convention (see https://css-tricks.com/bem-101/).

Giving mocha elements classes named mocha-stats-progress will eliminate conflicts with other libraries entirely.
@dasilvacontin dasilvacontin added the area: browser browser-specific label Aug 22, 2015
@Bamieh Bamieh closed this as completed Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: browser browser-specific
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dasilvacontin @Bamieh