Add cross-frame compatible Error checking for fail #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 19, 2015
|
👍 this has been an issue for me as well |
|
Looks good, thanks! |
danielstjules
added a commit
that referenced
this pull request
Jun 28, 2015
Add cross-frame compatible Error checking for fail
|
@danielstjules Do you know when the next patch version of Mocha is scheduled for release? Just wondering for when I can fix Konacha with this... |
This was referenced Sep 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing errors through between frames, AssertionErrors and the like will fail an instanceof check against Error. We need a compatible check. According to Mozilla Error Docs, Error prototype will always have message defined.
All tests pass: https://travis-ci.org/outdooricon/mocha/builds/67555897
It's worth noting that this currently prevents us from upgrading the Konacha project to use latest Mocha.