Convert BasicKeyRequest to KeyRequest to use cloudflare/cfssl 1.x.x #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
full diff: golang/crypto@v0.2.0...v0.3.0 Signed-off-by: Sebastiaan van Stijn <[email protected]>
This is asimple patch to update cloudfare/cfssl to a versioned release. It simply moves BasicKeyRequest to KeyRequest and update the vendor directory. It was tested with go test. Fix moby#3076 Signed-off-by: Robert-André Mauchin <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3077 +/- ##
==========================================
+ Coverage 61.71% 61.81% +0.09%
==========================================
Files 155 155
Lines 31145 31145
==========================================
+ Hits 19221 19252 +31
+ Misses 10381 10346 -35
- Partials 1543 1547 +4 |
|
Sorry for the long delay; the update brought a significant amount of new dependencies, so I opened some pull requests in cfssl to get rid of most of those. The good news is that most of them were accepted and now tagged. The v1.6.3 (and later) release contains those changes;
I did a quick rebase of your PR, and updated the cfssl version to v1.6.4 (current release) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is asimple patch to update cloudfare/cfssl to a versioned release. It simply moves BasicKeyRequest to KeyRequest and update the vendor directory.
It was tested with go test.
Fix #3076
Signed-off-by: Robert-André Mauchin [email protected]