Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: session not poisoned after terminal status update failure #1533

Closed
stevvooe opened this issue Sep 14, 2016 · 0 comments · Fixed by #1539
Closed

agent: session not poisoned after terminal status update failure #1533

stevvooe opened this issue Sep 14, 2016 · 0 comments · Fixed by #1539
Labels

Comments

@stevvooe
Copy link
Contributor

When the agent loses its session, it is supposed to stop interaction with the dispatcher and try to reestablish a session. This process has a backoff loop that handles this well. In the issue referenced below, when we have a failure to elect a leader, we see that an error to updating the task status doesn't cause the agent to fallback into the retry state, resulting in agent spamming log messages.

Please see moby/moby#26038 for further details.

To address this, we will have to poison the session when an invalid session is encountered.

cc @aaronlehmann @LK4D4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant