Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pkg/archive out of main module/repository #49069

Open
3 of 7 tasks
dmcgowan opened this issue Dec 11, 2024 · 3 comments
Open
3 of 7 tasks

Move pkg/archive out of main module/repository #49069

dmcgowan opened this issue Dec 11, 2024 · 3 comments
Assignees
Labels
area/go-sdk Changes affecting the Go SDK kind/refactor PR's that refactor, or clean-up code status/0-triage

Comments

@dmcgowan
Copy link
Member

dmcgowan commented Dec 11, 2024

Description

Summary

Move pkg/archive out of the main module into its own repository

Currently relevant dependencies

github.com/docker/docker/pkg/archive
  ├ github.com/docker/docker/pkg/idtools
  ├ github.com/docker/docker/pkg/ioutils
  ├ github.com/docker/docker/pkg/pools
  ├ github.com/docker/docker/pkg/system
  ├ github.com/moby/patternmatcher
  ├ github.com/moby/sys/sequential
  └ github.com/moby/sys/userns

github.com/docker/docker/pkg/idtools
  └ github.com/moby/sys/user

github.com/docker/docker/pkg/ioutils (nothing relevant)

github.com/docker/docker/pkg/pools
  └ github.com/docker/docker/pkg/ioutils

github.com/docker/docker/pkg/system (nothing relevant)

Proposal and steps

@dmcgowan dmcgowan added kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny status/0-triage kind/refactor PR's that refactor, or clean-up code and removed kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny labels Dec 11, 2024
@thaJeztah
Copy link
Member

@thaJeztah thaJeztah added the area/go-sdk Changes affecting the Go SDK label Dec 11, 2024
@dmcgowan
Copy link
Member Author

I think you could close those older issues.

Do the steps I outline sound reasonable to you? I'll open them one at a time to make sure it make sense along the way and I can turn this issue into check boxes.

@thaJeztah
Copy link
Member

Also opened a PR to remove use of pkg/errors; most errors were already using stdlib, and only 2 or 3 locations used pkg/errors; #49101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/go-sdk Changes affecting the Go SDK kind/refactor PR's that refactor, or clean-up code status/0-triage
Projects
Status: In Progress
Development

No branches or pull requests

2 participants