git: ensure file-looking git refs aren't parsed as URLs #4776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URLs that look like `./path/to/file` and `../path/to/file` definitely aren't git URLs - so we should bail out early. This was causing a weird issue where if you copied `./.git` this would be detected as a valid url parsing with `host = "."` and `path = "/git"`. The fix for this is to make sure that for these explicit file-like paths, we *never* parse them as url-refs. Also some tests to make sure this doesn't break again! Signed-off-by: Justin Chadwell <[email protected]>
|
I don't think this is a regression (from what I can tell), but potentially this is also a good backport candidate? |
|
ISTR I once added a test-case for the classic builder to make sure that it was able to build from a local directory named |
|
Yup, we still have those |
tonistiigi
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4326 (comment) (thanks @stephanos! 🎉)
URLs that look like
./path/to/fileand../path/to/filedefinitely aren't git URLs - so we should bail out early.This was causing a weird issue where if you copied
./.gitthis would be detected as a valid url parsing withhost = "."andpath = "/git". The fix for this is to make sure that for these explicit file-like paths, we never parse them as url-refs.Also some tests to make sure this doesn't break again!