Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verifying the images by using cosign for Dockerfile FROM images #2494

Open
Dentrax opened this issue Nov 30, 2021 · 3 comments
Open

verifying the images by using cosign for Dockerfile FROM images #2494

Dentrax opened this issue Nov 30, 2021 · 3 comments

Comments

@Dentrax
Copy link

Dentrax commented Nov 30, 2021

As we (@developer-guy) discussed a similar thing at containerd/nerdctl#577, @.AkihiroSuda proposed an idea to verify Dockerfile FROM images in nerdctl build and nerdctl compose up --build. We can traverse the entire base images since cosign already have a support for verifying signatures on the base images that specified in the Dockerfile.

# only verify the base image (the last FROM image)
$ cosign dockerfile verify --base-image-only <path/to/Dockerfile>

Additional Context

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Nov 30, 2021

From nerdctl build (and docker buildx) perspective, modifying BuildKit is probably not necessary if we can have cosign dockerfile resolve command proposed in sigstore/cosign#707 sigstore/cosign#648 .

nerdctl build (and docker buildx build) could exec cosign dockerfile resolve to convert the Dockerfile before calling BuildKit.

@developer-guy
Copy link

developer-guy commented Nov 30, 2021

cc: @dlorenc @imjasonh @n3wscott

@dlorenc
Copy link

dlorenc commented Nov 30, 2021

Nice! Yeah we can fix up that command. I think it has a few issues right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants