Add warning when passing an action to autorun

[jeffijoe]

I spent 30 minutes today wondering why my autorun wasn't triggering. Turns out it was because I was doing this:

autorun(action(() => {}))

and actions are untracked (as I found out in #490). I think it would be a good idea to add a development-only warning when attempting to set up autorun with an action.

Implementing it shouldn't be too difficult - the function being returned from action could have a tag (a Symbol or just a privatized key) that is checked when creating an autorun.

Example warning:

Warning: attempted to pass an action to autorun. Actions are untracked and will not trigger on state changes. Use `reaction` or wrap only your state modification code in an action.

[mweststrate]

Would you mind creating a PR? Should be pretty straightforward, since isAction already exists

[jeffijoe]

I can try, hehe. :)

[jeffijoe]

@mweststrate adding this check breaks existing tests.

This is all I added:

[jeffijoe]

It appears to be related to using spies.

[mweststrate]

can you turn it into a PR, then I'll verify. might be error in the test

Op zo 25 sep. 2016 16:09 schreef Jeff Hansen [email protected]:

It appears to be related to using spies.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#576 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABvGhCGKCeSlmHjICtpprGZFACeV3_YNks5qtoCIgaJpZM4KFvow
.

[jeffijoe]

Will do!

[mweststrate]

Released as part of 2.6.0

[jeffijoe]

Sweet!