Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Object API keys should also support observable arrays #1600

Closed
YarnSphere opened this issue Jun 20, 2018 · 1 comment
Closed

Comments

@YarnSphere
Copy link
Contributor

YarnSphere commented Jun 20, 2018

All other object API functions support objects, arrays, and maps. I find it arbitrary that only the keys function does not support arrays. array.keys() is a thing; as well as Object.keys(array).

I agree that it might seem like a useless functionality, but I believe it's worth it for API consistency: all functions should work on all types of collections.

I, in fact, have a use for keys where I'd like not to worry about the type of the underlying collection (though I admit it is not a common use-case).

I'd be happy to provide a PR if you agree with my suggestion.

mweststrate added a commit that referenced this issue Aug 14, 2018
Add support for obs. arrays on `keys`. Fixes #1600
@lock
Copy link

lock bot commented Jul 21, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or questions.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant