Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error in development when @observable is used on getters #1511

Merged
merged 1 commit into from
May 3, 2018

Conversation

quanganhtran
Copy link
Member

@quanganhtran quanganhtran commented Apr 21, 2018

This PR is to address #1454

The variant check is added to the property creator function. The caveat is that it throws when the target is initialized (even if the property being accessed is not the erroneous one).

Fixed random typos in comments that I came across.

  • Added unit tests
  • Updated changelog
  • Updated docs (either in the description of this PR as markdown, or as separate PR on the gh-pages branch. Please refer to this PR). For new functionality, at least API.md should be updated
  • Added typescript typings
  • Verified that there is no significant performance drop (npm run perf)

@coveralls
Copy link

coveralls commented Apr 21, 2018

Coverage Status

Coverage increased (+0.005%) to 92.975% when pulling 8cca76d on quanganhtran:master into dbe4c93 on mobxjs:master.

@mweststrate
Copy link
Member

Thanks!

@mweststrate mweststrate merged commit b0ee838 into mobxjs:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants