Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce distinction between DEV and PROD builds #813

Closed
mweststrate opened this issue Feb 2, 2017 · 4 comments
Closed

Introduce distinction between DEV and PROD builds #813

mweststrate opened this issue Feb 2, 2017 · 4 comments

Comments

@mweststrate
Copy link
Member

Can we lift on what most people do with React as well, e.g. use process.env.NODE_ENV substitutions and conditions?

Things that could be stripped on PROD builds:

@tanzim
Copy link

tanzim commented Feb 2, 2017

@mweststrate I can take this on if no one has shown interest yet. Minor caveat is I haven't worked with TS, so bootstrapping time might be a little longer for me :)

@mweststrate
Copy link
Member Author

Go for it! If you need process, you probably need put declare var process:any in somewhere, to signal that that is a globally available variable. Besides that typescript should hopefully not be too much in your way :)

@hccampos
Copy link

hccampos commented Feb 2, 2017

Cool stuff. Although MobX is not that big, it is always nice to get it a bit smaller. :)

@mweststrate
Copy link
Member Author

This issue will be fixed in MobX 4

@mweststrate mweststrate mentioned this issue Feb 27, 2018
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants