Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure in js-framework-benchmark #1667

Closed
krausest opened this issue Aug 6, 2018 · 1 comment
Closed

Test failure in js-framework-benchmark #1667

krausest opened this issue Aug 6, 2018 · 1 comment
Labels

Comments

@krausest
Copy link

krausest commented Aug 6, 2018

I recently updated mobx to 5.0.3 / mobx-react 5.2.3 in the js-framework-benchmark and ran into what I think looks like a regression for very large tables.
I've files the bug here krausest/js-framework-benchmark#427, but I'm not sure @mweststrate had a chance to take a look at it, so I decided to file the bug here as well.

How to reproduce:
git clone https://github.com/krausest/js-framework-benchmark.git
cd js-framework-benchmark
start the local web server on port 8080:
npm install
npm start
open a new terminal with js-framework-benchmark as current directory, then:
cd frameworks/keyed/react-mobX/
npm install
npm run build-dev
open http://localhost:8080/frameworks/keyed/react-mobX

Now observe the following:
click create 1,000 rows then append 1,000 rows. There'll be 2,000 rows.
click create 10,000 rows then append 1,000 rows. There'll be only 1,000 rows (not 11,000 as expected).
Similarly click create 1,000 and then click 10 times on 'append 1,000 rows'. As soon as there are more than 10,000 rows, the first 10,000 rows are removed and only the appended 1,000 rows are rendered.
The same code works when I downgrade to mobx 3.3.1 / mobx-react 4.3.4.

mweststrate added a commit that referenced this issue Aug 25, 2018
@mweststrate
Copy link
Member

Reproduced and fixed in 5.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants