Add MAESTRO_CLI_NO_ANALYTICS flag
#1848
Conversation
bartekpacia
force-pushed
the
fix/analytics_on_ci
branch
from
a27be00 to
5e2e8e7
Compare
| @@ -73,6 +77,13 @@ object Analytics { | |||
| fun maybeAskToEnableAnalytics() { | |||
| if (hasRunBefore) return | |||
|
|
|||
| // Fix for https://github.com/mobile-dev-inc/maestro/issues/1846 | |||
| if (CiUtils.getCiProvider() != null) { | |||
There was a problem hiding this comment.
Let's maybe give DISABLE_ANALYTICS_ENV_VAR false by default if its CI?
There was a problem hiding this comment.
We only need analytics if user is sourcing from CLI
There was a problem hiding this comment.
Are you sure? We set uuid to name of the CI service if we're running on CI:
which then gets uploaded to our backend:
I think it can be useful knowledge to know what CI service is most used*, so we would have some data if we will have to build integrations with CIs in the future.
*A problem here may be that we don't have UUIDs of specific CI installations. We would need to have separate "UUID" and "CI" values in the AnalyticsReport.
Otherwise analytics from various runs on CI get merged together.
|
Make sure to run ./maestro-ios-xctest-runner/build-maestro-ios-runner.sh with every swift change |
fix #1846