Fix labels #1762
Merged
Fix labels #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishbowler
commented
Jun 2, 2024
Comment on lines
+115
to
+126
| - swipe: | ||
| direction: DOWN | ||
| label: "Swipe down a bit" | ||
| - addMedia: | ||
| files: | ||
| - "023_image.png" | ||
| label: "Add a picture to the device" | ||
| - setAirplaneMode: | ||
| value: enabled | ||
| label: "Turn on airplane mode for testing" | ||
| - toggleAirplaneMode: | ||
| label: "Toggle airplane mode for testing" |
There was a problem hiding this comment.
These are all of the labelled commands that would otherwise have been outliers.
I've been through and checked that all of the other commands are covered by this test.
|
Rebased. |
| data class AddMediaCommand(val mediaPaths: List<String>): Command { | ||
| data class AddMediaCommand( | ||
| val mediaPaths: List<String>, | ||
| val label: String? |
There was a problem hiding this comment.
Shouldn't this be having a default valu?
There was a problem hiding this comment.
To default it explicitly to null?
maestro-orchestra/src/test/java/maestro/orchestra/yaml/YamlCommandReaderTest.kt
Outdated
Show resolved
Hide resolved
amanjeetsingh150
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds labels to the Swipe command, as well as the new addMedia and unreleased airplane mode commands.
Testing
Run all the unit / integration tests, as well as adding new contributions.
Issues Fixed
Fixes #1761