Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Modal & Off-Canvas do not reset default values on close. #744

Closed
grahamhency opened this issue Feb 12, 2021 · 0 comments · Fixed by #746
Closed

[BUG] Modal & Off-Canvas do not reset default values on close. #744

grahamhency opened this issue Feb 12, 2021 · 0 comments · Fixed by #746
Assignees
Labels
bug Something isn't working in progress Work on this issue is in progress

Comments

@grahamhency
Copy link
Contributor

Describe the bug
After opening a modal not in the default configuration, if you open a different modal the previous modal's options persist with the new modal.

To Reproduce
Steps to reproduce the behavior:

  1. Open a modal that has a modal option different than default (ex: modalSize)
  2. Close the modal
  3. Open a different modal that doesn't pass modal options
  4. The modal should be set to the modal options of the previous modal, this is the error.

Expected behavior
Whenever a modal is closed, the modal should reset its options to the default.

@grahamhency grahamhency added bug Something isn't working new issue This issue has yet to receive attention labels Feb 12, 2021
@grahamhency grahamhency self-assigned this Feb 12, 2021
@grahamhency grahamhency added in progress Work on this issue is in progress and removed new issue This issue has yet to receive attention labels Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in progress Work on this issue is in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant