Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Update Font Stacks #160

Closed
grahamhency opened this issue Sep 6, 2019 · 6 comments
Closed

[Chore] Update Font Stacks #160

grahamhency opened this issue Sep 6, 2019 · 6 comments
Assignees
Labels
chore General chore or maintenance task in progress Work on this issue is in progress

Comments

@grahamhency
Copy link
Contributor

What general chore or task would you like to see performed?

The font stacks need corrected.

Are there any specific steps you would like completed?

  1. Base font style: Roboto Light
  2. Header font style: Roboto, except for H1 which is Bryant
  3. Left navigation font style: Bryant
@grahamhency grahamhency added chore General chore or maintenance task new issue This issue has yet to receive attention labels Sep 6, 2019
@eligolding
Copy link
Contributor

except for H1 which is Bryant

Can you source that requirement? I don't see that documented in the DSM.

@grahamhency
Copy link
Contributor Author

grahamhency commented Sep 9, 2019

@eligolding in the Typography section it says:

Page Headers are Bryant Regular

Considering that there should only be one h1 per page we can probably assume that an h1 should be a page title. That being stated, I think we can say that any time an h1 is used, it should be a page title.

Thoughts on this? Alternatively, we could keep all h tags Roboto and implement some sort of page-title class.

@eligolding
Copy link
Contributor

@grahamhency Thanks I miss understood that line, thought it meant all headers.

Alternatively, we could keep all h tags Roboto and implement some sort of page-title class.

That does sit better with me. Makes less assumptions about when the h1 tag is being used, and keeps all the tags consistent.

But I'm fine either way.

@grahamhency
Copy link
Contributor Author

@eligolding all good, let's go with adding a utility class for page titles and Roboto for all of the headings. (.go-page-title maybe?)

@eligolding
Copy link
Contributor

@grahamhency Sounds like a plan.

@StevenUlmer StevenUlmer added in progress Work on this issue is in progress and removed new issue This issue has yet to receive attention labels Sep 12, 2019
@grahamhency grahamhency added this to the Needs Triaged milestone Sep 13, 2019
@grahamhency
Copy link
Contributor Author

@eligolding because UX decided to change the font, I've created an alternate issue for this with updated instructions that might be a bit more clear, #191. I also created an issue for the page title utility, #202.

As a result, I'm going to go ahead and close both this issue and it's associated PR. If you'd like to put up another PR, pointed at v1.3.0 for these issues that would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore General chore or maintenance task in progress Work on this issue is in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants