-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Rich text input #233
Merged
Merged
✨ Rich text input #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@brunobuddy In rich text yield component, We can add an ngIf to the "wrapper" div. And create the span to display the dash . |
SebConejo
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a Rich Text property type that shows a WYSIWYG editor on admin panel. It uses Quill through ngx-quill package.
The related doc PR has to be reviewed also.
How can it be tested?
1. Read the doc
Get the doc for rich text from the website repository and change the
docs/fetch-content.sh
content by this one:then run the docs from the website repository as explained in the readme file.
2. Follow the doc
Play around by adding a richText property and checking the list/detail/create/edit views.
Styling to be done
There is some styling to be done on this component:
General
Input
Yield
Impacted packages
Check the NPM packages that require a new publication or release:
Check list before submitting