Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/lint #232

Closed
wants to merge 9 commits into from
Closed

Feature/lint #232

wants to merge 9 commits into from

Conversation

brunobuddy
Copy link
Contributor

@brunobuddy brunobuddy commented Nov 21, 2024

Description

This PR adds Husky to the monorepo to implement an automatic linting script that triggers on commit.

The "lint" script has been implemented on the smaller packages and will be implemented on the bigger ones soon. This is the current situation on how the linting is implemented:

Packages:

  • add-manifest
  • core/admin
  • core/helpers
  • core/json-schema
  • core/types
  • core/manifest
  • js-sdk

Related Issues

#192

How can it be tested?

From the root run:

npm run lint

It should pass.

Now try to add a "wrong" code:

// packages/core/helpers/src/index.ts

[...]
// Replace the "string" type by "any" line 50
export function kebabize(str: any): string {
[...]

And run again:

npm run lint

This time it should fail

Impacted packages

Check the NPM packages that require a new publication or release:

Check list before submitting

  • I have performed a self-review of my code (no debugs, no commented code, good naming, etc.)
  • I wrote the relative tests
  • I created a PR for the documentation if necessary and attached the link to this PR
  • This PR is wrote in a clear language and correctly labeled

@brunobuddy brunobuddy requested a review from SebConejo November 21, 2024 10:05
@brunobuddy brunobuddy self-assigned this Nov 21, 2024
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
manifest-schema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 10:41am

brunobuddy added a commit that referenced this pull request Nov 26, 2024
@brunobuddy
Copy link
Contributor Author

brunobuddy commented Nov 28, 2024

This PR has been merged but it seems that Github has some problems with it:
image

I close the PR as it is already SUCCESFULLY MERGED and not CLOSED

@brunobuddy brunobuddy closed this Nov 28, 2024
@brunobuddy brunobuddy deleted the feature/lint branch November 28, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants