Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix annotation rejection idx #12895

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Commits on Oct 11, 2024

  1. Reject last sample of annotations

    - Keep bad annotations that end at the start sample (annotations that are potentialy one sample long): end = start
    - Do not discard bad annotations that are exactly one sample long: onset = end
    - Also discard last sample of bad annotation: end - start + 1
    richardkoehler committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5fbd36f View commit details
    Browse the repository at this point in the history
  2. Fix and add tests

    - Fix now broken tests
    - Add tests for annotations that are one sample long
    richardkoehler committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    47a0104 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    16dfd8a View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Configuration menu
    Copy the full SHA
    30ed414 View commit details
    Browse the repository at this point in the history
  2. Add include_last as argument to _annotations_starts_stops

    - Add include_last as keyword argument to _annotations_starts_stops
    - Adapt corresponding function call in `BaseRaw.get_data()`, and correspondingly remove +1 indexing of used samples
    - Update documentation of _annotations_starts_stops
    - Add tests for _annotations_starts_stops
    - Add towncrier entry for PR
    richardkoehler committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    9651cd0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7fb81fc View commit details
    Browse the repository at this point in the history