Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of montage files #6782

Closed
jasmainak opened this issue Sep 17, 2019 · 8 comments
Closed

Better handling of montage files #6782

jasmainak opened this issue Sep 17, 2019 · 8 comments

Comments

@jasmainak
Copy link
Member

When reading montage files, users seem to face a number of issues.

  1. Documentation of the different file formats is not clear. For example, *.hpts should not have a header and a column of type. This is not clearly explained anywhere. You cannot figure this out without looking at the code.

  2. Inconsistent handling of numpy versions when reading text files. Here it is handled properly: https://github.com/mne-tools/mne-python/blob/master/mne/channels/montage.py#L325-L328 but this is not the case in all calls. Ideally, this should be abstracted away into a private helper function.

maybe an easy issue for @fmamashli to solve who encountered this in the first place

@agramfort
Copy link
Member

agramfort commented Sep 18, 2019 via email

@massich
Copy link
Contributor

massich commented Sep 18, 2019

we bumped the minimum version of numpy. We no longer need to keep both versions of skip_row / header.

@fmamashli
Copy link
Contributor

We digitized the channels using a new system: Localite.
.hpts: we followed MNE manual: EEG, channels name, coordinates (x,y,z) in mm.
The coordinate system is RAS.

The problem was that in MNE-python, there was no good documentation on the format of the files and what exactly it should contain. like headers, columns, coordinate system.

@jasmainak
Copy link
Member Author

jasmainak commented Sep 18, 2019

also just to add to what @fmamashli said, see the documentation of mne-c. It is clearly mentioned what the format should look like. Otherwise, you start seeing obscure errors from np.loadtxt which are hard to debug

@agramfort
Copy link
Member

agramfort commented Sep 18, 2019 via email

@jasmainak
Copy link
Member Author

jasmainak commented Sep 22, 2019

We managed for now. But I would say you need a documentation page for montages analogous to this one for reading in raw files.

@jasmainak
Copy link
Member Author

Cool !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

5 participants