-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling of montage files #6782
Comments
FYI the read_montage is currently being deprecated in
#6764
to make sure we are addressing the issue @fmamashli
<https://github.com/fmamashli> can you clarify the usecase? How was the
.hpts
file produced? what does it contain? points in what coordinate system?
… |
we bumped the minimum version of numpy. We no longer need to keep both versions of skip_row / header. |
We digitized the channels using a new system: Localite. The problem was that in MNE-python, there was no good documentation on the format of the files and what exactly it should contain. like headers, columns, coordinate system. |
also just to add to what @fmamashli said, see the documentation of mne-c. It is clearly mentioned what the format should look like. Otherwise, you start seeing obscure errors from |
if you use the current master you can try this command:
https://mne.tools/dev/generated/mne.channels.make_dig_montage.html#mne.channels.make_dig_montage
provided you have the locations already read in python
you could ideally specify that the points are in MRI RAS and then it should
work just fine (hopefully).
share some fake data if needed.
… |
We managed for now. But I would say you need a documentation page for montages analogous to this one for reading in raw files. |
Cool ! |
When reading montage files, users seem to face a number of issues.
Documentation of the different file formats is not clear. For example, *.hpts should not have a header and a column of type. This is not clearly explained anywhere. You cannot figure this out without looking at the code.
Inconsistent handling of
numpy
versions when reading text files. Here it is handled properly: https://github.com/mne-tools/mne-python/blob/master/mne/channels/montage.py#L325-L328 but this is not the case in all calls. Ideally, this should be abstracted away into a private helper function.maybe an easy issue for @fmamashli to solve who encountered this in the first place
The text was updated successfully, but these errors were encountered: