Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC improve description of dipole_fit procedure #6431

Closed
tomMoral opened this issue Jun 7, 2019 · 2 comments · Fixed by #6949
Closed

DOC improve description of dipole_fit procedure #6431

tomMoral opened this issue Jun 7, 2019 · 2 comments · Fixed by #6949
Labels

Comments

@tomMoral
Copy link
Contributor

tomMoral commented Jun 7, 2019

The example showing how to use dipole_fit do not give any information on how the source localization is done.

I guess this is probably planned to land in issue #5944 but is it possible to get some resources (like the original ECD paper) to document the general idea. I might give a try if I find some time.

@drammock
Copy link
Member

drammock commented Jun 7, 2019

@tomMoral I'm slowly working through the tutorials but I don't have a lot of experience with dipole fitting anyway so your input would be helpful. If you open a PR I'll gladly review / help.

FYI #5944 is now sort of stale; the changes are being tackled one tutorial at a time instead of waiting until everything is finished and trying to merge them all in at once.

@agramfort
Copy link
Member

I think the question is what is a good academic reference for the dipole fitting algorithm.

maybe @mshamalainen can help here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

4 participants