Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter logo in docs should not be colored #12285

Closed
cbrnr opened this issue Dec 8, 2023 · 2 comments · Fixed by #12301
Closed

Twitter logo in docs should not be colored #12285

cbrnr opened this issue Dec 8, 2023 · 2 comments · Fixed by #12301
Labels

Comments

@cbrnr
Copy link
Contributor

cbrnr commented Dec 8, 2023

Twitter is the only colored icon on our docs website:

Screenshot 2023-12-08 at 23 05 51

It should be gray like all the other icons.

@cbrnr cbrnr added the DOC label Dec 8, 2023
@drammock
Copy link
Member

This is inherited from the website theme. In the latest version of the theme the twitter icon color goes away (but that's actually a bug in the theme due to changing the icon from the "square" version to just the bird, but not changing the associated CSS selector). The theme also defines brand-appropriate colors for GitLab and Bitbucket. Github is grey because that's their brand.

In our MNE-Python CSS, we actually define colors for the discord icon:

--mne-color-discord: #5865F2;

as well as light and dark variant colors for discourse, github, and mastadon icons, e.g.:

--mne-color-github: rgb(240, 246, 252); /* from their logo SVG */
--mne-color-discourse: #FFF9AE; /* from their logo SVG */
--mne-color-mastodon: #858AFA; /* www.joinmastodon.org/en/branding */

but for some reason they aren't getting used, so that's also a bug.

Finally, one might argue we should change the twitter logo to an X logo (but that should probably happen at the theme level).

With all that said: do you still think they should be all grey, or should we try to fix the broken color display of the other icons?

@cbrnr
Copy link
Contributor Author

cbrnr commented Dec 16, 2023

Thanks for investigating @drammock! Either way is fine with me, although I have a slight preference for using color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants