-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twitter logo in docs should not be colored #12285
Comments
This is inherited from the website theme. In the latest version of the theme the twitter icon color goes away (but that's actually a bug in the theme due to changing the icon from the "square" version to just the bird, but not changing the associated CSS selector). The theme also defines brand-appropriate colors for GitLab and Bitbucket. Github is grey because that's their brand. In our MNE-Python CSS, we actually define colors for the discord icon: mne-python/doc/_static/style.css Line 9 in b1329c3
as well as light and dark variant colors for discourse, github, and mastadon icons, e.g.: mne-python/doc/_static/style.css Lines 46 to 48 in b1329c3
but for some reason they aren't getting used, so that's also a bug. Finally, one might argue we should change the twitter logo to an X logo (but that should probably happen at the theme level). With all that said: do you still think they should be all grey, or should we try to fix the broken color display of the other icons? |
Thanks for investigating @drammock! Either way is fine with me, although I have a slight preference for using color. |
Twitter is the only colored icon on our docs website:
It should be gray like all the other icons.
The text was updated successfully, but these errors were encountered: