You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Extra [attributes] are not supposed to be part of the RawEyelink class. You need to put it all in _raw_extras[0]. This can be a dict, too. This is going to be a big change so you don't need to do it here -- we can figure it out later. I'll create a new issue about adding a test for this since it's possible there are other readers that need to be updated, too.
I propose we add a test to _test_raw_reader that there aren't extra attributes added to the class other than what's expected based on BaseRaw. In principle maybe this should involve an ABC and some automated checking, but to KISS I might start by manually coding a test in _test_raw_reader. I don't expect it to be more than a dozen lines or so.
The text was updated successfully, but these errors were encountered:
Extra [attributes] are not supposed to be part of the
RawEyelink
class. You need to put it all in_raw_extras[0]
. This can be a dict, too. This is going to be a big change so you don't need to do it here -- we can figure it out later. I'll create a new issue about adding a test for this since it's possible there are other readers that need to be updated, too.Originally posted by @larsoner in #11823 (comment)
I propose we add a test to
_test_raw_reader
that there aren't extra attributes added to the class other than what's expected based onBaseRaw
. In principle maybe this should involve an ABC and some automated checking, but to KISS I might start by manually coding a test in_test_raw_reader
. I don't expect it to be more than a dozen lines or so.The text was updated successfully, but these errors were encountered: