Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Some raw classes use attributes rather than ._raw_extras #11825

Closed
larsoner opened this issue Jul 22, 2023 · 0 comments · Fixed by #11826
Closed

BUG: Some raw classes use attributes rather than ._raw_extras #11825

larsoner opened this issue Jul 22, 2023 · 0 comments · Fixed by #11826

Comments

@larsoner
Copy link
Member

Extra [attributes] are not supposed to be part of the RawEyelink class. You need to put it all in _raw_extras[0]. This can be a dict, too. This is going to be a big change so you don't need to do it here -- we can figure it out later. I'll create a new issue about adding a test for this since it's possible there are other readers that need to be updated, too.

Originally posted by @larsoner in #11823 (comment)

I propose we add a test to _test_raw_reader that there aren't extra attributes added to the class other than what's expected based on BaseRaw. In principle maybe this should involve an ABC and some automated checking, but to KISS I might start by manually coding a test in _test_raw_reader. I don't expect it to be more than a dozen lines or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant