Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace legacy StreamViewer with a Viewer based on the Stream API #174

Closed
wants to merge 19 commits into from

Conversation

mscheltienne
Copy link
Member

@mscheltienne mscheltienne commented Nov 7, 2023

Closes #51

Idea: Use pytest-qt for tests

@mscheltienne mscheltienne marked this pull request as draft November 7, 2023 15:15
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 127 lines in your changes are missing coverage. Please review.

Comparison is base (9c18ac0) 80.85% compared to head (7b1390e) 69.55%.
Report is 1 commits behind head on main.

❗ Current head 7b1390e differs from pull request most recent head 85f811b. Consider uploading reports for the commit 85f811b to get more accurate results

Files Patch % Lines
mne_lsl/viewer/axis.py 0.00% 51 Missing ⚠️
mne_lsl/viewer/trace.py 0.00% 40 Missing ⚠️
mne_lsl/viewer/gui.py 0.00% 36 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #174       +/-   ##
===========================================
- Coverage   80.85%   69.55%   -11.31%     
===========================================
  Files          22       33       +11     
  Lines        2340     3166      +826     
  Branches      532      693      +161     
===========================================
+ Hits         1892     2202      +310     
- Misses        363      866      +503     
- Partials       85       98       +13     
Flag Coverage Δ
unittests 69.42% <0.00%> (-11.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mscheltienne mscheltienne marked this pull request as ready for review February 21, 2024 11:54
@mscheltienne mscheltienne marked this pull request as draft February 21, 2024 11:54
@mscheltienne mscheltienne closed this by deleting the head repository Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overhaul of the StreamViewer
1 participant