Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remaning TODO #5

Closed
8 tasks done
larsoner opened this issue Mar 31, 2023 · 14 comments
Closed
8 tasks done

MAINT: Remaning TODO #5

larsoner opened this issue Mar 31, 2023 · 14 comments

Comments

@larsoner
Copy link
Member

larsoner commented Mar 31, 2023

Then I think the workflow will be all set!

@alexrockhill
Copy link
Collaborator

Does it have to be on conda-forge to pass the CIs and open a PR in mne-python? Or is that okay to go ahead with?

@larsoner
Copy link
Member Author

larsoner commented Apr 3, 2023

Yes because we want to test that it actually works with MNE-Python's environment.yml

@larsoner
Copy link
Member Author

larsoner commented Apr 3, 2023

... but if you want to start at the MNE-Python end you can, we just shouldn't merge it until we can add mne-gui-addons to environment.yml over there

@larsoner
Copy link
Member Author

larsoner commented Apr 3, 2023

... but conda-forge is usually a very quick process, and maintenance burden is very low with automerge over there. Once you assent in conda-forge/staged-recipes#22453 (review) then it'll probably be working in a day or two at most

@larsoner
Copy link
Member Author

@alexrockhill if you want I think another doable step is to move tutorials/clinical/10_ieeg_localize.py from MNE-Python over to this repo. At the MNE-Python end you can add a redirect to doc/conf.py that redirects to this repo's auto_examples/10_ieeg_localize.html or whatever.

@alexrockhill
Copy link
Collaborator

Ok, I can do that once the PR merges

@larsoner
Copy link
Member Author

... and examples/preprocessing/locate_ieeg_micro.py can also be migrated

@alexrockhill
Copy link
Collaborator

I can do these PRs but I'm not sure how to redirect the example url, do we do that anywhere else? I think you mentioned it was as just editing the conf.py, I can look into that when I get a chance.

@alexrockhill
Copy link
Collaborator

Gotcha thanks, I'll do that ASAP

@alexrockhill
Copy link
Collaborator

Is this all done?

@larsoner
Copy link
Member Author

larsoner commented May 2, 2023

Still needs conda-forge/staged-recipes#22453 :(

@alexrockhill
Copy link
Collaborator

Ok now should be good

@larsoner
Copy link
Member Author

larsoner commented May 9, 2023

Agreed!

@larsoner larsoner closed this as completed May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants