Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: linters, CIs, packaging metadata #1174

Closed
4 tasks done
sappelhoff opened this issue Sep 30, 2023 · 6 comments · Fixed by #1203
Closed
4 tasks done

maint: linters, CIs, packaging metadata #1174

sappelhoff opened this issue Sep 30, 2023 · 6 comments · Fixed by #1203
Labels
code-health maint
Milestone
0.14

Comments

@sappelhoff
Copy link
Member

sappelhoff commented Sep 30, 2023 •
edited
Loading 

          I would say this is ready to go.

In follow-up PRs we should

Originally posted by @hoechenberger in #1173 (comment)
@sappelhoff sappelhoff changed the title maint: update linters and CIs and packaging metadata maint: linters, CIs, packaging metadata, switch to hatchling and vcs Nov 5, 2023
@sappelhoff
Copy link
Member Author

Also switching to hatchling and hatchling-vcs. See:

See also:

@sappelhoff sappelhoff added this to the 0.14 milestone Nov 6, 2023
@sappelhoff
Copy link
Member Author

sappelhoff commented Nov 23, 2023 •
edited
Loading

note: also revamp MANIFEST.in file (

mne-bids/MANIFEST.in

Line 1 in d9d26e5

include MANIFEST.in
) ... only relevant if staying with setuptools

edit: https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html#using-manifest-in

also just did this commit: b57fd07

... because I figured out it's simply wrong: we do not have py2 support, hence no universal wheel

@ofek
Copy link

ofek commented Dec 4, 2023

Maintainer of Hatch here! Let me know if I can help

@sappelhoff sappelhoff mentioned this issue Dec 7, 2023
Merged
2 tasks
@sappelhoff
Copy link
Member Author

@hoechenberger should we just remove black and rely on ruff format?

@hoechenberger
Copy link
Member

I would say so. It works beautifully with MNE

@sappelhoff sappelhoff mentioned this issue Dec 7, 2023
Merged
@sappelhoff sappelhoff changed the title maint: linters, CIs, packaging metadata, switch to hatchling and vcs maint: linters, CIs, packaging metadata Dec 7, 2023
@sappelhoff
Copy link
Member Author

putting off switching to hatching and vcs to a later point in time, #1203 is the last PR in this series for now

hoechenberger added a commit to hoechenberger/mne-bids that referenced this issue Dec 7, 2023
@hoechenberger
Use hatchling as build backend
d7c118c 
Also dynamically generate version number via hatch-vcs

Addresses mne-tools#1174
hoechenberger added a commit to hoechenberger/mne-bids that referenced this issue Dec 7, 2023
@hoechenberger
Use hatchling as build backend
c45dbfc 
Also dynamically generate version number via hatch-vcs

Addresses mne-tools#1174
@hoechenberger hoechenberger mentioned this issue Dec 7, 2023
Merged
5 tasks
hoechenberger added a commit to hoechenberger/mne-bids that referenced this issue Dec 7, 2023
@hoechenberger
Use hatchling as build backend
fdbf6eb 
Also dynamically generate version number via hatch-vcs

Addresses mne-tools#1174
hoechenberger added a commit that referenced this issue Dec 7, 2023
@hoechenberger
MRG: Use hatchling as build backend (#1204)
ee9efd9 
* Use hatchling as build backend

Also dynamically generate version number via hatch-vcs

Addresses #1174

* Add excludes

* Add .git_archival.txt

* Remove MANIFEST.in

* Update Makefile

* Fix filename

* Consistency

* Remove check-manifest

* Remove deps

* Update changelog

* Update formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-health maint
Projects
None yet
Milestone
0.14
Development

Successfully merging a pull request may close this issue.

Remove flake8, pydocstyle, black, etc. in favor of ruff sappelhoff/mne-bids
3 participants
@hoechenberger @sappelhoff @ofek