Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(integration): enable recheck tx mode #5

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

GAtom22
Copy link

@GAtom22 GAtom22 commented Dec 22, 2022

Closes: #XXX

Description

@mmsqe thanks for your contribution!

Changes:

  • Enable ReCheckTx mode: previously, transactions were failing due to a bug. This was fixed on PR #1566
  • Fix target height on upgrade test: When running the test_upgrade.py, got error upgrade cannot be scheduled in the past: invalid request:. Refactored to avoid this happening

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe merged commit 7845edf into mmsqe:stable_test Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants