Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics should not break for different indices. #179

Closed
mmschlk opened this issue Jul 30, 2024 · 0 comments
Closed

Metrics should not break for different indices. #179

mmschlk opened this issue Jul 30, 2024 · 0 comments
Assignees

Comments

@mmschlk
Copy link
Owner

mmschlk commented Jul 30, 2024

ATM, computing test metrics (MSE, MAE, SSE, ...) will break with a ValueError if two interaction indices are compared with different indices. While this might be good for technical reasons (some indices cannot semantically be compared to others) for an experimentation tool this might be too restrictive.

Proposal: In instances like described above, not a ValueError should be returned but a Warning and the metrics should be made compatible.

@mmschlk mmschlk self-assigned this Jul 30, 2024
@mmschlk mmschlk moved this to 🏗 In progress in shapiq development Jul 30, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in shapiq development Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant