Make feature_row work well with all layouts

[lsolesen]

• This is a question about using the theme.
• This is a feature request.
• I believe this to be a bug with the theme.
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.

---

Environment informations

• Minimal Mistakes version:
• Jekyll version:
• GitHub Pages hosted: yes/no
• Operating system:

---

Expected behavior

The feature_row helper is really nice - and really close to look nice with other layouts than ´splash´. I would be really cool if small tweaks would be made to make feature_row usable on all layouts.

Steps to reproduce the behavior

Here you see how close it is to look nice on e.g. the ´archive´ layout.

It seeks that these tweaks needs to be made for other layouts:

• fill container in width
• make sure that the headline is scaled down a bit and less top margin

That would make them usable in other layouts also, which will make the feature_row even more useful.

[mmistakes]

Do you have a repo with this example? I'd like to drop it in to a test page and see how hard it would be to add some CSS to make feature rows more portable.

[lsolesen]

On this branch - https://github.com/vih/historie/tree/yearbook

When build the screenshot is from /yearbooks/2017/ and there is an example on "left" and "center" on /yearbooks/

[lsolesen]

Just an extra question regarding feature_row. On :hover on either the picture or the headline, the headlines get underlined, and that makes me want to click them (as they act like a link), but that is not possible, which seems a little counterintuitive. Does this qualify for another issue - or is it on purpose?

[mmistakes]

Thanks.

And agree on the hover state of feature rows. That's something I recently removed but haven't pushed up yet.

[mmistakes]

Was a pretty easy fix so I pushed a couple of updates. Here's an example of an archive page with feature rows placed after (might have to flush your browser's cache to get the latest CSS).

• Post archive with feature rows (source file)

In your example where you're using a grid wrapper to expand the main content's width, you need to place the feature row includes inside of that <div>. That will allow the feature rows to fill the entire area without the space on the right.

{% assign site_posts = site.posts | where: "tags", page.title | sort: "date" %}

<div class="grid__wrapper">
  {% include feature_row id="intro" type="center" %}

  {% for post in site_posts %}
    {% include archive-single.html %}
  {% endfor %}

  <h2>Har du også læst?</h2>
  {% include feature_row type="left" %}
  {% include feature_row id="feature_row_2" type="right" %}
  {% include feature_row %}
</div>

[mmistakes]

Example with updated CSS:

[lsolesen]

Awesome. Thanks for your work on this theme. The theme is reason I like Jekyll so much :)