Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update diff to be based off v2 #292

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Update diff to be based off v2 #292

wants to merge 13 commits into from

Conversation

Banaanae
Copy link
Collaborator

@Banaanae Banaanae commented Sep 22, 2024 •
edited
Loading

Changes

  • Update ahk wrapper to v2
  • Update mergely to v5
  • Runs under WebView2
  • Smaller overall size (1.44MB -> 668KB, mostly from deleting the ahk bin, as its safe to assume most have v2 now)

TODO

  • Receive message when wv is loaded and then inject mergely
  • Update v2Converter
  • Add buttons present in old VisualDiff
  • Remove  after cursor
  • Better way to send scripts (large scripts don't load)

@Banaanae Banaanae marked this pull request as ready for review October 3, 2024 05:09
@Banaanae
Copy link
Collaborator Author

Banaanae commented Oct 3, 2024

@andymbody could you test this? iirc you're on win 7 which doesn't have native support for webview2

We could either prompt the user to open an online diff tool (like in #280) or prompt the user to download the last supported version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Banaanae