Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create flatpak distributable, preferrably distribute via FlatHub #8

Open
scottAnselmo opened this issue Jul 21, 2020 · 3 comments
Open

Comments

@scottAnselmo
Copy link

The flatpak on FlatHub for pegasus-frontend has been useful in working around Qt framework related issues. Having a flatpak for the editor would be nice to avoid similar Qt runtime/build issues in addition to making it generally easier to install on various Linux distros via a simple flatpak install [...]

@mmatyas
Copy link
Owner

mmatyas commented Jul 21, 2020

Sounds good! Will try to set things up when I have a little time.

@TiZ-HugLife
Copy link

I actually forked the Pegasus repo on Flathub to try and add this to it and do a pull request so you could do flatpak run --command=pegasus-metadata-editor org.pegasus_frontend.Pegasus, but it fails to build.

/run/build/pegasus-metadata-editor/thirdparty/SortFilterProxyModel/sorters/rolesorter.cpp: In member function ‘virtual int qqsfpm::RoleSorter::compare(const QModelIndex&, const QModelIndex&, const qqsfpm::QQmlSortFilterProxyModel&) const’:
/run/build/pegasus-metadata-editor/thirdparty/SortFilterProxyModel/sorters/rolesorter.cpp:61:19: error: no match for ‘operator<’ (operand types are ‘QVariant’ and ‘QVariant’)
   61 |     if (leftValue < rightValue)
      |         ~~~~~~~~~ ^ ~~~~~~~~~~
      |         |           |
      |         QVariant    QVariant

@mmatyas
Copy link
Owner

mmatyas commented Apr 29, 2021

Yes, the SortFilterProxyModel dependency has some old style code, which will fail to build with the latest Qt if deprecated Qt features are disabled. Make sure you don't have any QT_DISABLE_DEPRECATED_BEFORE defines when you build, and make sure that Qt 5 is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants